1088491 - [Music]Broken screen is shown while unplugging the usb

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[ranjith253]

User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/37.0.2062.124 Safari/537.36

Steps to reproduce:

Device: Flame
Gaia version: 2.0

1. settings->keyboards->select keyboards->Add more keyboards->Add chines language keyboard
2. settings->usb storage enable
3. Push 30 songs on the the device storage.
4. Music - Albums tab - Album List Scroll down - Search Music with some char - 
Searched screen - plugged USB cable - Unplug USB cable - enter some char with keypad


Actual results:

A broken screen is shown with both tiles view & album view.
Attached screen shot for reference  


Expected results:

Tiles view should be shown completely on the screen.

Comment 1

[ranjith253]

Attachment: IssueScreenShot

Comment 2

[ranjith253]

Hi

Comment 3

[ranjith253]

Hi Dominic,

This issue can be easily reproducible only when Chinese  language keyboard is added.
As you know when user plugs the usb cable , music app will remove all the current views &
moves to default tiles view . For switching between two view music app uses transform in css .
In this scenario transformations for removing album view is not completed. So we are able to see partial
album view in the tiles view.

Can please help me in finding the root cause of the issue?

Comment 4

[mail2tapas]

- The issue is easily reproducible if we play the music in background and execute the scenario.
- It looks like the search window is trying to retain the search, but as per implementation the search window should hide.
- We made below changes, it seems the issue is resolved, Please suggest if the approach is correct.
- We have made changes to call the hideSearch() before changing the Mode.

File : Music.js
Function : stopPlayingAndReset()

Original Code :
........
 TabBar.option = 'mix';
 ModeManager.start(MODE_TILES);
 TilesView.hideSearch();
........


Changed Code :
................
 TabBar.option = 'mix';
 TilesView.hideSearch();
 ModeManager.start(MODE_TILES); 
.................

Comment 5

[Rachelle Yang [:ryang][[e-mail]]]

Hi, 

Would you please submit a PR for review per comment 4?
Thank you very much!

Comment 6

[ranjith253]

Attachment: PR

Providing PR on behalf of Tapas for review.

Comment 7

[Dominic Kuo [:dkuo]]

Comment on attachment 8514801 [details]
PR

Thanks Ranjith, I haven't look into this issue myself but if the patch does fix the problem, it seems no harm for the original behaviour so looks good to me, but would you please add some comments to explain why we make this change before land it? thanks!

Comment 8

[mail2tapas]

The details updated in comment 4.
Since the problem is with the search window not closed properly, it tries to retain the search text, which causes the broken UI.[partial display of Music Window and search Window]
So we made changes to hide the search window before changing the mode to tile view.

Comment 9

[BMO Automation]

Firefox OS is not being worked on