1088497 - Implement NewChannel2 in mailnews

Status: RESOLVED FIXED

(MailNews Core :: Networking, defect)

Description

[Kent James (:rkent)]

Bug 1067471 breaks mailnews by adding a new method to nsIProtocolHandler, newChannel2. There are lots of other implications of this as well that we need to investigate, see bug 1038756.

Comment 1

[Kent James (:rkent)]

Attachment: Add NewChannel2 to mailnews

I don't think this is the end of the issues that will result from the ongoing Netwerk changes, but at least this builds and passes a smoke test.

Comment 2

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8510853 [details] [diff] [review]
Add NewChannel2 to mailnews

Review of attachment 8510853 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/addrbook/src/nsAddbookProtocolHandler.cpp
@@ +118,5 @@
>  {
> +  return NewChannel2(aURI, nullptr, _retval);
> +}
> +
> +NS_IMETHODIMP 

EWHITESPACE

Comment 3

[Kent James (:rkent)]

Attachment: with js protocol handlers included

I'll be mostly AFK for the next few days, so please move this ahead without me if there are further issues.

Comment 4

[Joshua Cranmer [:jcranmer]]

https://hg.mozilla.org/comm-central/rev/0e9dfec40751

Comment 5

[Florian Quèze [:florian]]

Thanks for fixing this in chat/ too! While I'm happy it's fixed and don't think a review from a chat peer was needed here, I would appreciate if in similar situations in the future you could ensure at least one chat peer is in the cc list of the bug. Thanks!

Comment 6

[Kent James (:rkent)]

(In reply to Florian Quèze [:florian] [:flo] from comment #5)
> Thanks for fixing this in chat/ too! While I'm happy it's fixed and don't
> think a review from a chat peer was needed here, I would appreciate if in
> similar situations in the future you could ensure at least one chat peer is
> in the cc list of the bug. Thanks!

OK that's a good approach to this kind of issue.

BTW the chat changes were added per an IRC request from jcranmer.