Closed Bug 1088520 Opened 10 years ago Closed 10 years ago

"mach ide eclipse" generate empty project on Linux

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla36

People

(Reporter: TYLin, Assigned: TYLin)

Details

Attachments

(1 file, 1 obsolete file)

After using "mach ide eclipse" to generate eclipse project on Linux machine, I cannot see any source files in the "Project explorer" in eclipse. However, it works well on Mac OS. I use Eclipse CDT 8.5.

The generated eclipse folder contains:
$ tree .
.
├── gecko
│   └── RunConfigurations
│       └── gecko.launch
├── Gecko
└── RemoteSystemsTempFiles

And the project name I saw in "Project explorer" is "Gecko".
I add a print in [1], and got the following log. That "Gecko" folder with capital "G" should be generated by eclipse.

0:28.87 /home/tlin/Projects/gecko-dev/obj-firefox/_virtualenv/bin/python /home/tlin/Projects/gecko-dev/obj-firefox/config.status --backend=CppEclipse
Reticulating splines...
dir_name /home/tlin/Projects/eclipse_obj-firefox/gecko
dir_name /home/tlin/Projects/eclipse_obj-firefox/gecko/.settings
dir_name /home/tlin/Projects/eclipse_obj-firefox/gecko/RunConfigurations
dir_name /home/tlin/Projects/eclipse_obj-firefox/.metadata/.plugins/org.eclipse.core.runtime/.settings
dir_name /home/tlin/Projects/eclipse_obj-firefox/.metadata/.plugins/org.eclipse.cdt.core
Create.
Opening 'Gecko'.
Refreshing '/Gecko'.

[1] http://hg.mozilla.org/mozilla-central/annotate/9781037ac408/python/mozbuild/mozbuild/backend/cpp_eclipse.py#l77
Use "gecko" with small letter 'g' for both project dir and the project
name in .project.
Attachment #8510871 - Flags: review?(gps)
Ah the joys of case-insensitive file systems.
Comment on attachment 8510871 [details] [diff] [review]
Fix empty eclipse project generated on Linux.

Review of attachment 8510871 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/backend/cpp_eclipse.py
@@ +26,5 @@
>      def _init(self):
>          CommonBackend._init(self)
>  
>          self._paths_to_defines = {}
> +        self._project_name = 'gecko'

Can you make it 'Gecko'?
Attachment #8510871 - Flags: review?(gps) → review+
Addressed comment 4.

Use "Gecko" with captical letter 'G' for both project dir and the
project name in .project.
Attachment #8510871 - Attachment is obsolete: true
Attachment #8510967 - Flags: review+
This change is NPOTB. Thanks.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8a799dd8a11c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: