Closed Bug 1088523 Opened 10 years ago Closed 10 years ago

[Follow-up][FTE][2.2] About Firefox OS page is missing Firefox OS link / words in the welcome message

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::First Time Experience
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S8 (7Nov)

People

(Reporter: mancas, Assigned: mancas)

References

Details

(Keywords: regression)

Attachments

(1 file)

String IDs changed
46 bytes, text/x-github-pull-request
zbraniecki
: review+
flod
: feedback+
Details | Review 
The string IDs must be updated since the strings have been modified.
Thanks Manuel for taking care of this!
Attached file String IDs changed — 

        Attachment #8510873 -
        Flags: review?(gandalf)

        Attachment #8510873 -
        Flags: feedback?(francesco.lodolo)

    
    

    
  
Comment on attachment 8510873 [details] [review]
String IDs changed

Nit: drop the localization comments, not needed anymore.

Strings look good to me, I'll let gandalf check the code. Thanks for the quick patch.

        Attachment #8510873 -
        Flags: feedback?(francesco.lodolo) → feedback+

    
    

    
  
Hey! I've made the changes you commented in github.

Thanks!

    
    

    
  
Comment on attachment 8510873 [details] [review]
String IDs changed

r+

        Attachment #8510873 -
        Flags: review?(gandalf) → review+

    
  
Keywords: checkin-needed

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/e7ad20e27cc488377ece72f9d9e89c9339fdf855
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S8 (7Nov)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: