1088527 - BluetoothOppManager.IsConnected() returns false even though OPP profile has connected.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Jamin Liu [:jaliu][:Jamin]]

BluetoothOppManager.IsConnected() couldn't represent the connection status
of Opp profile since it only return true if there is an ongoing file-transfer session.

This function was used to named |IsTransferring()| in Bug 827267, however,
it was renamed to |IsConnected()| when Bug 842948 landed.

Modified |IsConnected()| to let it indicate whether profile connected or not.

Comment 1

[Jamin Liu [:jaliu][:Jamin]]

Attachment: Modify BluetoothOppManager.IsConnected() to indicate whether profile is connected or not. (v1)

Comment 2

[Ben Tian (inactive)]

Comment on attachment 8510876 [details] [diff] [review]
Modify BluetoothOppManager.IsConnected() to indicate whether profile is connected or not. (v1)

Review of attachment 8510876 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Please 1) modify BluetoothOppManager under bluez and bluetooth2 as well (total 4 files) and 2) ensure the patch is landed together with bug 1066461 gaia change.

Comment 3

[Jamin Liu [:jaliu][:Jamin]]

Attachment: Modify BluetoothOppManager.IsConnected() to indicate whether profile is connected or not. (v2), r=btian

- Revise previous patch based on #comment 2

Comment 4

[Jamin Liu [:jaliu][:Jamin]]

The patch of Bug 1066461 has been landed to m-c.

I've put #Attachment #8510876 [details] [diff] on try server.
https://tbpl.mozilla.org/?tree=Try&rev=6c0c240d310f

Comment 5

[Ben Tian (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/288ea8616ac1

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/288ea8616ac1