avoid passing unconstrained inline-size to block reflow

RESOLVED FIXED in mozilla36

Status

()

Core
Layout: Block and Inline
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla36
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
When setting up constraints in a reflow state for an orthogonal child frame, we should avoid passing NS_UNCONSTRAINEDSIZE as the inline size of the containing block when we call frame->ComputeSize.

This is a follow-up to what was started in bug 1061170.
Blocks: 1088261
(Assignee)

Comment 1

3 years ago
Created attachment 8511004 [details] [diff] [review]
Don't pass NS_UNCONSTRAINEDSIZE as inline-size constraint to ComputeSize.

This seems like a reasonable first cut here, and stops the frequent warnings I've been seeing from ComputeSize.
Attachment #8511004 - Flags: review?(smontagu)
(Assignee)

Updated

3 years ago
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #8511004 - Flags: review?(smontagu) → review+
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a638e05ed88a
Target Milestone: --- → mozilla36
https://hg.mozilla.org/mozilla-central/rev/a638e05ed88a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.