Closed Bug 1088612 Opened 10 years ago Closed 7 years ago

Add slider/range simpleprefs-type

Categories

(Add-on SDK Graveyard :: General, defect, P2)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: flying-sheep, Unassigned, Mentored)

References

Details

(Whiteboard: [good next bug]) 

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141021172801

Steps to reproduce:

I’m writing the second addon-sdk where I’m missing a slider type:

I think it’s not that uncommon to allow a user to select from a range between minimum and maximum.

I think we should implement both a min and a max property for the integer preference type, and if both are specified, replace the textbox with a slider + textbox.
Marking this as P2 for now, patches are welcome though!
Priority: -- → P2
Mentor: evold
Whiteboard: [good first bug]
Hi,
Can you please help me with reproducing the bug and patching it.
Thanks
Flags: needinfo?(evold)
(In reply to ksh.shrm1 from comment #2)
> Hi,
> Can you please help me with reproducing the bug and patching it.
> Thanks

Hey, I'm going to change this to good next bug, as it requires some familiarity with our test suites.

As far as implementation goes, we can ignore cfx and python related code for this, and we should only need to update this file https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/preferences/native-options.js to check for the new type and render it https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/preferences/native-options.js#L113-L169.
Flags: needinfo?(evold)
Whiteboard: [good first bug] → [good next bug]
https://bugzilla.mozilla.org/show_bug.cgi?id=1399562
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.