The list of supported properties in the computed-view should be resolved on the server-side

RESOLVED INACTIVE

Status

()

Firefox
Developer Tools: Computed Styles Inspector
P2
normal
RESOLVED INACTIVE
4 years ago
a day ago

People

(Reporter: pbro, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
See: http://mxr.mozilla.org/mozilla-central/source/browser/devtools/styleinspector/computed-view.js#571

This is what the computed-view uses to determine the list of css properties the current target supports.
It does this by accessing the computed-style of a documentElement object on the toolbox-side.

This means that the list of supported properties will always be the list of properties the "client-side" supports (i.e. the toolbox), not the list of properties the current target supports.

This is especially a problem when debugging ios/chrome devices/browsers through the VALENCE addon. But I can imagine this being a problem too when debugging another gecko version (via remote connection).

We should make this code execute remotely, on the target instead.

However (and I haven't really taken the time to confirm this yet) it seems to me that we could skip this step altogether, by refactoring a little bit the way the computed-view works by only displaying the properties returned by the server when calling 'getComputed'.
Inspector Bugs Triage - Filter on CLIMBING SHOES

Patrick, computed-view.js does not exist anymore. Is this still an issue ?
Flags: needinfo?(pbrosset)
Priority: -- → P3
(Reporter)

Comment 2

2 years ago
Yes this is still an issue. The code was moved around, that's all.
The computed-view now lives here: https://dxr.mozilla.org/mozilla-central/source/devtools/client/inspector/computed/computed.js

In particular, the list of existing properties is computed here:
https://dxr.mozilla.org/mozilla-central/source/devtools/client/inspector/computed/computed.js#630-647

This should be done server-side because this depends on the engine currently rendering the page.
Component: Developer Tools: Inspector → Developer Tools: Computed Styles Inspector
Flags: needinfo?(pbrosset)
Priority: P3 → P2

Comment 3

a day ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Last Resolved: a day ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.