1088628 - implement Accessible::Attributes for proxies

Status: RESOLVED FIXED

Description

[Trevor Saunders (:tbsaunde)]

Comment 1

[Trevor Saunders (:tbsaunde)]

Created attachment 8511012 [details] [diff] [review]
implement Accessible::Attributes for proxies

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8511012 [details] [diff] [review]
implement Accessible::Attributes for proxies

Review of attachment 8511012 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, with a nit etc.

::: accessible/atk/moz.build
@@ +49,5 @@
>  
>  if CONFIG['MOZ_ENABLE_DBUS']:
>      CXXFLAGS += CONFIG['MOZ_DBUS_CFLAGS']
> +
> +    include('/ipc/chromium/chromium-config.mozbuild')

I don't know the build stuff.

::: accessible/ipc/DocAccessibleChild.cpp
@@ +103,5 @@
> +    NS_ENSURE_SUCCESS(rv, false);
> +
> +    nsAutoString value;
> +    rv = propElem->GetValue(value);
> +    NS_ENSURE_SUCCESS(rv, false);

(Note to self: I think returning false indicates catastrophic failure and communication channels are disconnected)

::: accessible/ipc/ProxyAccessible.h
@@ +13,5 @@
>  
>  namespace mozilla {
>  namespace a11y {
>  
> +  class Attribute;

nit: remove indent.

Comment 3

[Trevor Saunders (:tbsaunde)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/339521504f27

Comment 4

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/339521504f27