implement Accessible::Attributes for proxies

RESOLVED FIXED in mozilla36

Status

()

Core
Disability Access APIs
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

unspecified
mozilla36
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8511012 [details] [diff] [review]
implement Accessible::Attributes for proxies
(Assignee)

Updated

3 years ago
Attachment #8511012 - Flags: review?(dbolter)
Comment on attachment 8511012 [details] [diff] [review]
implement Accessible::Attributes for proxies

Review of attachment 8511012 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, with a nit etc.

::: accessible/atk/moz.build
@@ +49,5 @@
>  
>  if CONFIG['MOZ_ENABLE_DBUS']:
>      CXXFLAGS += CONFIG['MOZ_DBUS_CFLAGS']
> +
> +    include('/ipc/chromium/chromium-config.mozbuild')

I don't know the build stuff.

::: accessible/ipc/DocAccessibleChild.cpp
@@ +103,5 @@
> +    NS_ENSURE_SUCCESS(rv, false);
> +
> +    nsAutoString value;
> +    rv = propElem->GetValue(value);
> +    NS_ENSURE_SUCCESS(rv, false);

(Note to self: I think returning false indicates catastrophic failure and communication channels are disconnected)

::: accessible/ipc/ProxyAccessible.h
@@ +13,5 @@
>  
>  namespace mozilla {
>  namespace a11y {
>  
> +  class Attribute;

nit: remove indent.
Attachment #8511012 - Flags: review?(dbolter) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/339521504f27

Comment 4

3 years ago
https://hg.mozilla.org/mozilla-central/rev/339521504f27
Assignee: nobody → tbsaunde+mozbugs
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36

Updated

3 years ago
Depends on: 1092507
You need to log in before you can comment on or make changes to this bug.