Closed
Bug 1088628
Opened 7 years ago
Closed 7 years ago
implement Accessible::Attributes for proxies
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: tbsaunde, Assigned: tbsaunde)
References
Details
Attachments
(1 file)
7.49 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8511012 -
Flags: review?(dbolter)
Comment 2•7 years ago
|
||
Comment on attachment 8511012 [details] [diff] [review] implement Accessible::Attributes for proxies Review of attachment 8511012 [details] [diff] [review]: ----------------------------------------------------------------- r=me, with a nit etc. ::: accessible/atk/moz.build @@ +49,5 @@ > > if CONFIG['MOZ_ENABLE_DBUS']: > CXXFLAGS += CONFIG['MOZ_DBUS_CFLAGS'] > + > + include('/ipc/chromium/chromium-config.mozbuild') I don't know the build stuff. ::: accessible/ipc/DocAccessibleChild.cpp @@ +103,5 @@ > + NS_ENSURE_SUCCESS(rv, false); > + > + nsAutoString value; > + rv = propElem->GetValue(value); > + NS_ENSURE_SUCCESS(rv, false); (Note to self: I think returning false indicates catastrophic failure and communication channels are disconnected) ::: accessible/ipc/ProxyAccessible.h @@ +13,5 @@ > > namespace mozilla { > namespace a11y { > > + class Attribute; nit: remove indent.
Attachment #8511012 -
Flags: review?(dbolter) → review+
Assignee | ||
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/339521504f27
![]() |
||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/339521504f27
Assignee: nobody → tbsaunde+mozbugs
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•