Closed
Bug 1088636
Opened 9 years ago
Closed 9 years ago
Desktop ToS url should use hello.firefox.com not call.mozilla.com
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox33 unaffected, firefox34+ fixed, firefox35+ verified, firefox36 verified)
backlog | Fx34+ |
People
(Reporter: standard8, Assigned: standard8)
Details
(Whiteboard: [landed in fx-team])
Attachments
(1 file)
1.24 KB,
patch
|
NiKo
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
We need to update the value in the preference file to use the new hello.firefox.com domain.
Updated•9 years ago
|
backlog: --- → Fx34+
Assignee | ||
Comment 1•9 years ago
|
||
Simple one-line patch.
Attachment #8511030 -
Flags: review?(mdeboer)
Assignee | ||
Updated•9 years ago
|
Attachment #8511030 -
Flags: review?(mdeboer) → review?(nperriault)
Assignee | ||
Comment 2•9 years ago
|
||
To verify: - Open up Firefox Desktop - Open the Loop panel - If the ToS message isn't displayed: -- Go into about:config -- Reset "loop.seenToS" -- Re-open the panel Click the ToS link, it should navigate to https://hello.firefox.com/legal/terms/
Comment on attachment 8511030 [details] [diff] [review] Desktop ToS url should use hello.firefox.com not call.mozilla.com. Review of attachment 8511030 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=me.
Attachment #8511030 -
Flags: review?(nperriault) → review+
Assignee | ||
Updated•9 years ago
|
Iteration: --- → 36.1
Whiteboard: [landed in fx-team]
Target Milestone: --- → mozilla36
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/05b4f6cb488d
Comment 5•9 years ago
|
||
Comment on attachment 8511030 [details] [diff] [review] Desktop ToS url should use hello.firefox.com not call.mozilla.com. Approval Request Comment [Feature/regressing bug #]: Update ToS URL to match new location [User impact if declined]: client would continue to fetch the terms of service from the old location [Describe test coverage new/current, TBPL]: manually verified [Risks and why]: No risk outside of Hello; virtually no risk to Hello; product and legal need us to use the latest URL location [String/UUID change made/needed]: No strings
Attachment #8511030 -
Flags: approval-mozilla-beta?
Attachment #8511030 -
Flags: approval-mozilla-aurora?
Comment 6•9 years ago
|
||
[Tracking Requested - why for this release]: The ToS URL location moved
tracking-firefox34:
--- → ?
Updated•9 years ago
|
status-firefox33:
--- → unaffected
status-firefox34:
--- → affected
status-firefox35:
--- → affected
status-firefox36:
--- → affected
tracking-firefox35:
--- → +
https://hg.mozilla.org/mozilla-central/rev/05b4f6cb488d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 8•9 years ago
|
||
Testing in 10/25 Nightly; looks good.
Comment 9•9 years ago
|
||
Sorry - "Tested", not Testing. Verified on Nightly
Comment 10•9 years ago
|
||
Comment on attachment 8511030 [details] [diff] [review] Desktop ToS url should use hello.firefox.com not call.mozilla.com. Aurora+ The plan is to verify on Aurora on Sunday before uplift for beta4.
Attachment #8511030 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 12•9 years ago
|
||
Verified on Aurora Nightly 10/26 Linux
Updated•9 years ago
|
Comment 13•9 years ago
|
||
Comment on attachment 8511030 [details] [diff] [review] Desktop ToS url should use hello.firefox.com not call.mozilla.com. Beta+
Attachment #8511030 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in
before you can comment on or make changes to this bug.
Description
•