1088678 - [Integration] CellBroadcast tests are failing in v2.1

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alberto Pastor [:albertopq]]

Can be reproed locally. 

 1) mozApps CellBroadcastSystem is shown when a message arrives:
05:14:30     INFO -    JavaScriptError: (17) TypeError: window.wrappedJSObject.cellBroadcastSystem is undefined
05:14:30     INFO -    Remote Stack:
05:14:30     INFO -    execute_script @undefined, line undefined
05:14:30     INFO -    inline javascript, line 63

Comment 1

[Alberto Pastor [:albertopq]]

It seems that Bug 971479 needs to be uplifted, or the tests disabled. Kevin?

Comment 2

[Kevin Grandon :kgrandon]

We can't uplift that as it's refactoring work. The test introduced for bug 1082917 needs to be reworked.

Alberto - can you take care of this since you're the test author?

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/marionette/cell_broadcast_system_test.js

Comment 3

[Kevin Grandon :kgrandon]

(We should only modify the test for v2.1, and the pull request should be made against the v2.1 branch)

Comment 4

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25531

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8511877 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25531

LGTM, thanks.

Comment 6

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/16b7f74375ac32e123ad81338371d43de0a1470c

Comment 7

[Alberto Pastor [:albertopq]]

(In reply to Kevin Grandon :kgrandon from comment #6)
> In master:
> https://github.com/mozilla-b2g/gaia/commit/
> 16b7f74375ac32e123ad81338371d43de0a1470c

I guess you mean in v2.1 :)