Hour format 12 hour format Fire an alarm permafail on 2.1

RESOLVED FIXED

Status

Firefox OS
Gaia::Clock
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: daleharvey, Assigned: evanxd)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I can reproduce this locally
Blocks: 1088675
Evan, could you look at this? It seems stuck waiting for marionette-apps to transition back to the Clock app. Locally, I get the following stack:

 1) Hour format 12 hour format Fire an alarm:
     
  Error: timeout exceeded!
      at Object.Client.waitForSync (/home/marcus/moz/gaia/node_modules/marionette-client/lib/marionette/client.js:682:16)
      at Object.Client.waitFor (/home/marcus/moz/gaia/node_modules/marionette-client/lib/marionette/client.js:650:60)
      at waitForAppSync (/home/marcus/moz/gaia/node_modules/marionette-apps/lib/waitforapp.js:51:10)
      at waitForApp (/home/marcus/moz/gaia/node_modules/marionette-apps/lib/waitforapp.js:21:5)
      at /home/marcus/moz/gaia/node_modules/marionette-apps/lib/switchtoapp.js:25:12
      at /home/marcus/moz/gaia/node_modules/marionette-apps/lib/getapp.js:83:12
      at Object.<anonymous> (/home/marcus/moz/gaia/node_modules/marionette-apps/lib/mgmt.js:58:14)
      at Object.Client._handleCallback (/home/marcus/moz/gaia/node_modules/marionette-client/lib/marionette/client.js:484:23)
      at /home/marcus/moz/gaia/node_modules/marionette-client/lib/marionette/client.js:510:21
      at TcpSync.send (/home/marcus/moz/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:153:10)
      at Object.send (/home/marcus/moz/gaia/node_modules/marionette-client/lib/marionette/client.js:457:36)
      at Object.Client._sendCommand (/home/marcus/moz/gaia/node_modules/marionette-client/lib/marionette/client.js:503:19)
      at Object._executeScript (/home/marcus/moz/gaia/node_modules/marionette-client/lib/marionette/client.js:1468:19)
      at Object.executeAsyncScript (/home/marcus/moz/gaia/node_modules/marionette-client/lib/marionette/client.js:1249:19)
      at Object.Mgmt.getAll (/home/marcus/moz/gaia/node_modules/marionette-apps/lib/mgmt.js:37:19)
      at list (/home/marcus/moz/gaia/node_modules/marionette-apps/lib/list.js:14:20)
      at getApp (/home/marcus/moz/gaia/node_modules/marionette-apps/lib/getapp.js:45:10)
      at switchToApp (/home/marcus/moz/gaia/node_modules/marionette-apps/lib/switchtoapp.js:20:10)
      at Object.AlarmActions.fire (/home/marcus/moz/gaia/apps/clock/test/marionette/lib/alarm_actions.js:117:25)
      at Context.<anonymous> (/home/marcus/moz/gaia/apps/clock/test/marionette/hour_format_test.js:22:13)
      at callFn (/home/marcus/moz/gaia/node_modules/mocha/lib/runnable.js:223:21)
      at Test.Runnable.run (/home/marcus/moz/gaia/node_modules/mocha/lib/runnable.js:216:7)
      at Runner.runTest (/home/marcus/moz/gaia/node_modules/mocha/lib/runner.js:373:10)
      at /home/marcus/moz/gaia/node_modules/mocha/lib/runner.js:451:12
      at next (/home/marcus/moz/gaia/node_modules/mocha/lib/runner.js:298:14)
      at /home/marcus/moz/gaia/node_modules/mocha/lib/runner.js:308:7
      at next (/home/marcus/moz/gaia/node_modules/mocha/lib/runner.js:246:23)
      at Object._onImmediate (/home/marcus/moz/gaia/node_modules/mocha/lib/runner.js:275:5)
      at processImmediate [as _immediateCallback] (timers.js:330:15)
Flags: needinfo?(evanxd)
(Assignee)

Comment 2

3 years ago
Marcus, sure, I'll take a look.
Assignee: nobody → evanxd
Flags: needinfo?(evanxd)
(Assignee)

Comment 3

3 years ago
Created attachment 8511839 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25523
(Assignee)

Comment 4

3 years ago
Comment on attachment 8511839 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25523

Marcus,

In v2.1 branch, we need to use the marionette-apps newer than version 0.3.9[1] to wait for some System app's states. So let's update the node modules.

[1] https://github.com/mozilla-b2g/gaia-node-modules/commit/e769a868d7f302310ffac684cd7b226dc88b90b2
Attachment #8511839 - Flags: review?(m)
(Assignee)

Comment 5

3 years ago
And this updates could also fix other related issues.
Comment on attachment 8511839 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25523

Cool, thanks.
Attachment #8511839 - Flags: review?(m) → review+
(Assignee)

Comment 7

3 years ago
Marcus, thanks for the review.
(Assignee)

Comment 8

3 years ago
v2.1 branch: https://github.com/mozilla-b2g/gaia/commit/a0174f7166745256aaca1cb3aa9f894033fbffa6
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.