If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

e10s -- Lots of tests disabled because of promiseTabLoadEvent - should actually be fine?

RESOLVED WORKSFORME

Status

()

Firefox
General
RESOLVED WORKSFORME
3 years ago
3 years ago

People

(Reporter: Gijs, Assigned: mconley)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(e10sm4+)

Details

(Reporter)

Description

3 years ago
As in summary. Per discussion on #fx-team with mconley today, we think (and some spot-testing says) that promiseTabLoadEvent works because of the shimming. We should investigate re-enabling the tests that were disabled for e10s because of their use of promiseTabLoadEvent.
(In reply to :Gijs Kruitbosch from comment #0)
> As in summary. Per discussion on #fx-team with mconley today, we think (and
> some spot-testing says) that promiseTabLoadEvent works because of the
> shimming. We should investigate re-enabling the tests that were disabled for
> e10s because of their use of promiseTabLoadEvent.

SGTM - the shims have improved since those tests were disabled, so I'd expect *some* to now pass.  Note however that in most cases, these tests were disabled because the *first* problem found was the use of promiseTabLoadEvent - you can expect some of these tests will then fail for other reasons not related to this function.  So what should probably happen is:

* See if the test passes.
* If not: file/find a bug that describes the new failure state and update the manifest to reflect the "new" reason it remains disabled.
* If so: re-enable the test.
(Assignee)

Updated

3 years ago
tracking-e10s: --- → m4+
(Assignee)

Updated

3 years ago
Assignee: nobody → mconley
(Assignee)

Comment 2

3 years ago
Hey Gijs - a quick dxr is only showing a single test that was disabled because of promiseTabLoadEvent (that'd be browser_bug1015721.js). Am I missing some, or was that all?
Flags: needinfo?(gijskruitbosch+bugs)
(Reporter)

Comment 3

3 years ago
(In reply to Mike Conley (:mconley) - Needinfo me! from comment #2)
> Hey Gijs - a quick dxr is only showing a single test that was disabled
> because of promiseTabLoadEvent (that'd be browser_bug1015721.js). Am I
> missing some, or was that all?

Hm, I think I enabled (some of) the others. In any case, over in bug 1080801 I noticed that at least that test still fails, but we have bug 1056146 for that. I think we can close this WFM.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(gijskruitbosch+bugs)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.