1088691 - e10s -- Lots of tests disabled because of promiseTabLoadEvent - should actually be fine?

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[:Gijs (he/him)]

As in summary. Per discussion on #fx-team with mconley today, we think (and some spot-testing says) that promiseTabLoadEvent works because of the shimming. We should investigate re-enabling the tests that were disabled for e10s because of their use of promiseTabLoadEvent.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

(In reply to :Gijs Kruitbosch from comment #0)
> As in summary. Per discussion on #fx-team with mconley today, we think (and
> some spot-testing says) that promiseTabLoadEvent works because of the
> shimming. We should investigate re-enabling the tests that were disabled for
> e10s because of their use of promiseTabLoadEvent.

SGTM - the shims have improved since those tests were disabled, so I'd expect *some* to now pass.  Note however that in most cases, these tests were disabled because the *first* problem found was the use of promiseTabLoadEvent - you can expect some of these tests will then fail for other reasons not related to this function.  So what should probably happen is:

* See if the test passes.
* If not: file/find a bug that describes the new failure state and update the manifest to reflect the "new" reason it remains disabled.
* If so: re-enable the test.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hey Gijs - a quick dxr is only showing a single test that was disabled because of promiseTabLoadEvent (that'd be browser_bug1015721.js). Am I missing some, or was that all?

Comment 3

[:Gijs (he/him)]

(In reply to Mike Conley (:mconley) - Needinfo me! from comment #2)
> Hey Gijs - a quick dxr is only showing a single test that was disabled
> because of promiseTabLoadEvent (that'd be browser_bug1015721.js). Am I
> missing some, or was that all?

Hm, I think I enabled (some of) the others. In any case, over in bug 1080801 I noticed that at least that test still fails, but we have bug 1056146 for that. I think we can close this WFM.