1088720 - Closed windows with _shouldRestore=true are revived in the wrong order

Status: NEW

(Firefox :: Session Restore, defect, P3)

Description

[Tim Taubert [:ttaubert] (inactive)]

On Windows/Linux we restore windows closed in succession until quitting. They are however "revived" (moved to the list of open windows) in the wrong order so that we currently create the window last that was closed last.

Bug 1073992 has a test for that one can steal.

Comment 1

[tabmix.onemen]

I think we can save window.__SSi when we add winData to closedWindows, we can save it outside winData.

In onClose:
>          this._closedWindows.unshift(winData);
>          let closedWindowData = {state: winData};
>#ifndef XP_MACOSX
>          // Until we decide otherwise elsewhere, this window is part of a series
>          // of closing windows to quit.
>          closedWindowData._shouldRestore = true;
>+         closedWindowData._index = aWindow.__SSi.replace("window", "");
>#endif
>          this._closedWindows.unshift(closedWindowData);

later in getCurrentState, we can sort closedWindows list before we add closed windows back to open windows list.

looking at the code in getCurrentState, i don't think that we update selectedWindow properly when we move closed windows to open windows.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:dao, could you have a look please?
For more information, please visit auto_nag documentation.