Closed
Bug 1088779
Opened 10 years ago
Closed 10 years ago
KeyError thrown when ET connection error returns error for get_involved.
Categories
(Websites :: Basket, defect)
Websites
Basket
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pmac, Assigned: pmac)
Details
It's causing the task to fail to retry. https://errormill.mozilla.org/web-prod/basket/group/173526/
Comment 1•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/basket https://github.com/mozilla/basket/commit/2ed9bb1a4f647ecbd9bc1fcd437ceec42711a322 Fix bug 1088779: Fix ET error handling around views and tasks. This refactors a lot about how ET errors are handled. They were being converted to dicts of error information which needed to be detected and dealt with by calling functions. Now they raise exceptions with proper information attached that can bubble up in tasks to cause retries, or be converted to error reponses in views. https://github.com/mozilla/basket/commit/c78d28ae903947fe9c3bfc73ea341b81313498f9 Merge pull request #120 from pmclanahan/fix-get-involved-et-error-1088779 Fix bug 1088779: Fix ET error handling around views and tasks.
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•