1088789 - Undefined negative-space CSS variable

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Dave Townsend [:mossop]]

Seeing lots of these errors while running tests on fx-team right now:

Property contained reference to invalid variable.  Error in parsing value for 'transform'.  Falling back to 'initial'." {file: "chrome://browser/skin/browser.css" line: 7287 column: 226408 source: " translateY(calc(0px - var(--negative-space)))"}

negative-space doesn't seem to be defined anywhere.

Comment 1

[Brian Grinstead [:bgrins]]

Dang, that should have been --space-above-tabbar.  I'll submit a fix

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: variable-fix.patch

This was a mistake between reviews.  Because of a limitation with variables where I couldn't do: -var(--foo) to get a negated version of the variable I originally just added an extra variable like this:

--space-above-tabbar: 9px;
--negative-space: -9px;

Then we figured out that you could do this instead and not have to duplicate the variable name:

calc(0px - var(--foo))

So I switched to the expression but forgot to change the name in this attachment: https://bugzilla.mozilla.org/attachment.cgi?bugid=1088789&action=enter :(

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8511196 [details] [diff] [review]
variable-fix.patch

Review of attachment 8511196 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks for the back-story.

Comment 4

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/1c7ed7ed67ab

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1c7ed7ed67ab

Comment 6

[Eddy Bruel [:ejpbruel]]

Lande this on gum:
https://hg.mozilla.org/projects/gum/rev/e7ee9481e0a7

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e7ee9481e0a7