Closed Bug 1088800 Opened 8 years ago Closed 8 years ago

Apps fail to launch on b2g desktop with OOP enabled

Categories

(Firefox OS Graveyard :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rwood, Assigned: fabrice)

Details

Attachments

(1 file, 1 obsolete file)

Start b2g desktop in OOP mode, i.e.:

rwood@ubuntu:~/b2g-desktop-dwn/b2g$ ./b2g-bin -oop -profile gaia/profile

Then attempt to start an app. App fails to start, with this error in stdout:

JavaScript error: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/touch-events.js, line 26: Error: Permission denied to pass object to exported function

Using today's b2g desktop nightly on Ubuntu x86_64.
Attached patch desktop-oop-touch.patch (obsolete) — Splinter Review
We fail with :
JavaScript error: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/touch-events.js, line 198: Error: Permission denied to pass object to exported function

Which is https://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/touch-events.js#198

Bobby, setting allowCrossOriginArguments "fixes" the issue but is that something we want/can do on a mozbrowser iframe?
Attachment #8511353 - Flags: feedback?(bobbyholley)
Comment on attachment 8511353 [details] [diff] [review]
desktop-oop-touch.patch

Review of attachment 8511353 [details] [diff] [review]:
-----------------------------------------------------------------

So, there's a bunch of things wrong with this. What we have here is basically chrome code that wants to talk to chrome code, but we have to round-trip through untrusted content because the API doesn't use WebIDL. If it did, we could just use Xrays (and kill the unsafe Xray waiver), and everything would be fine.

In the mean time, we definitely shouldn't be turning off the security feature here. Instead, the call in touch-events.js should create content arrays (rather than chrome arrays).

Do we have a bug on file for moving this API to WebIDL? Who owns it, and how hard would it be?
Attachment #8511353 - Flags: feedback?(bobbyholley) → feedback-
Thanks Bobby, that's what I expected ;)

I don't know of any plan to move the mozbrowser api to webidl. It's a very special snowflake...
Cloning all the non primitive values.
Assignee: nobody → fabrice
Attachment #8511353 - Attachment is obsolete: true
Attachment #8511573 - Flags: review?(bobbyholley)
Attachment #8511573 - Flags: review?(bobbyholley) → review+
https://hg.mozilla.org/mozilla-central/rev/50c2a228bebe
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.