1088800 - Apps fail to launch on b2g desktop with OOP enabled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Robert Wood [:rwood]]

Start b2g desktop in OOP mode, i.e.:

rwood@ubuntu:~/b2g-desktop-dwn/b2g$ ./b2g-bin -oop -profile gaia/profile

Then attempt to start an app. App fails to start, with this error in stdout:

JavaScript error: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/touch-events.js, line 26: Error: Permission denied to pass object to exported function

Using today's b2g desktop nightly on Ubuntu x86_64.

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: desktop-oop-touch.patch

We fail with :
JavaScript error: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/touch-events.js, line 198: Error: Permission denied to pass object to exported function

Which is https://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/touch-events.js#198

Bobby, setting allowCrossOriginArguments "fixes" the issue but is that something we want/can do on a mozbrowser iframe?

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 8511353 [details] [diff] [review]
desktop-oop-touch.patch

Review of attachment 8511353 [details] [diff] [review]:
-----------------------------------------------------------------

So, there's a bunch of things wrong with this. What we have here is basically chrome code that wants to talk to chrome code, but we have to round-trip through untrusted content because the API doesn't use WebIDL. If it did, we could just use Xrays (and kill the unsafe Xray waiver), and everything would be fine.

In the mean time, we definitely shouldn't be turning off the security feature here. Instead, the call in touch-events.js should create content arrays (rather than chrome arrays).

Do we have a bug on file for moving this API to WebIDL? Who owns it, and how hard would it be?

Comment 3

[[:fabrice] Fabrice Desré]

Thanks Bobby, that's what I expected ;)

I don't know of any plan to move the mozbrowser api to webidl. It's a very special snowflake...

Comment 4

[[:fabrice] Fabrice Desré]

Attachment: desktop-oop-touch.patch

Cloning all the non primitive values.

Comment 5

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/50c2a228bebe

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/50c2a228bebe