1088813 - [Calendar] The word 'null' is appearing underneath calendar notifications in the drop-down menu

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Rachel Pribble [:rpribble]]

Attachment: Screenshot.png

Description:
The word null is appearing beneath calendar notifications in the pull down menu.

Prerequisites:
1) Have an event set on an online calendar (gmail) with a notification that will appear immediately. ex: An event tomorrow with a one day reminder.

Repro Steps:
1) Update a Flame device to BuildID: 20141024040202
2) Launch calendar
3) Drawer icon > settings > add an account
4) Sign in to the account with the event
5) Pull down the notifications menu to observe he calendar notifiction that appears
  
Actual:
The word 'null' is appearing below calendar event notifications.
  
Expected: 
'Null' does not appear in notifications.
  
Environmental Variables:
Device: Flame 2.2 Master KK (319 MB)
BuildID: 20141024040202 (full flash)
Gaia: d893a9b971a0f3ee48e5a57dca516837d92cf52b
Gecko: a5ee2769eb27
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 36.0a1 (2.2 Master)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
  
Repro frequency: 5/5
See attached: Screenshot, logcat

Comment 1

[Rachel Pribble [:rpribble]]

Attachment: Logcat.txt

Comment 3

[Miller Medeiros [:millermedeiros]]

probably a regression introduced by Bug 1042939

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25633

Just need to check for event description before sending over to alarms api I think.

Comment 5

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8513752 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25633

unit tests looks way better! and I wrote a very similar `waitFor` helper today, which means it'll be very useful.

Comment 6

[Gareth Aye [:gaye] (back from PTO)]

I have written waitFor at least 10 times in my life :(

Comment 7

[Gareth Aye [:gaye] (back from PTO)]

Landed on master https://github.com/mozilla-b2g/gaia/commit/8cdc5e128d3da7dc514b97a1f62906df5a35deb2

Comment 8

[Edward Chen[:edchen]]

[Environment]
Gaia-Rev        5ae28ff11b982e2bd7d1aa097cda131536952bdc
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/a926116946f8
Build-ID        20141111160205
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  39
FW-Date         Thu Oct 16 18:19:14 CST 2014
Bootloader      L1TC00011880

[Result]
PASS