1089002 - ./mach reftest error: runreftest.py: error: could not find the application path, --appname must be specified

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Mats Palmgren (inactive)]

# ./mach reftest  layout/reftests/bugs/reftest.list 
 0:00.08 /usr/bin/make -C . -j15 -s -w reftest
 0:00.17 make: Entering directory `/md1/objdir/md1/src/inbound'
 0:00.27 Usage: runreftest.py [options]
 0:00.27 
 0:00.27 runreftest.py: error: could not find the application path, --appname must be specified
 0:00.28 make: Leaving directory `/md1/objdir/md1/src/inbound'

Comment 1

[Mats Palmgren (inactive)]

After reverting bug 1083279 it works fine again.

Comment 2

[Nick Alexander :nalexander [he/him]]

mats: what application ('mobile/android', 'browser', etc) are you building?  It's possible I made a mistake in my conditional in Bug 1083279.

Comment 3

[Mats Palmgren (inactive)]

Firefox, mozilla-inbound debug build on Linux64.

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to Mats Palmgren (:mats) from comment #3)
> Firefox, mozilla-inbound debug build on Linux64.

Thanks.  This sure looks like a weirdness with defaults, default=, and store.  I'll r? you on a fix.

Comment 5

[Mats Palmgren (inactive)]

Attachment: fix?

I think it's just a typo, this fixes the problem for me.
(You use options.app in main.)

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8511410 [details] [diff] [review]
fix?

Review of attachment 8511410 [details] [diff] [review]:
-----------------------------------------------------------------

It's fine by me if it works for you.  If you look back at the original code, the default setting was in the declaration with a default=.  I might go back to that, because the appname vs. app feels wrong to me.  Your call.

Comment 7

[Mats Palmgren (inactive)]

No problem, it's better you fix it the right way.  It would be good to have a fix
soon though.  Thanks.

Comment 8

[Brian Marshall]

(In reply to Nick Alexander :nalexander from comment #6)
> I might go back to that, because the appname vs. app feels wrong to me.

FWIW, it's because OptionParser.set_defaults uses the destination name (dest="app") instead of the option name.

Comment 9

[Peter Van der Beken [:peterv]]

Can we get a fix in soon please?

Comment 10

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/b0956a9f57a9

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b0956a9f57a9