Closed Bug 1089020 Opened 6 years ago Closed 6 years ago

Hide the "cancel all jobs" button for non-try trees

Categories

(Tree Management :: Treeherder, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: KWierso, Assigned: KWierso)

References

Details

Attachments

(3 files)

I've clicked cancel all way too many times on m-c when I'm just trying to click the button to the left of it to access the links to mc-merge or self-serve.

Bug 1074858 wants to make the cancel all button prompt before it kills everything. 
Bug 1075473 wants to let users with is_staff go ahead and use cancel all for non-try, but just make it more obvious that it's affecting non-try stuff.

Both of those are good ideas, but there's been no activity in either bug.

I propose we just hide the buttons on non-try for now until we can get the UX a little better.
Attachment #8511430 - Flags: review?(emorley)
Assignee: nobody → kwierso
Status: NEW → ASSIGNED
OS: Windows 8.1 → All
Priority: -- → P2
Hardware: x86_64 → All
Comment on attachment 8511430 [details] [review]
Link to pull request 249

Could you switch this to a check for the repo group "try", rather than name?
Also, does the layout look ok with the button removed?

Thank you for taking a look at this :-)
Attachment #8511430 - Flags: review?(emorley) → review-
Flags: needinfo?(kwierso)
Attached image non-try.png
Flags: needinfo?(kwierso)
Comment on attachment 8511430 [details] [review]
Link to pull request 249

Edited the pull request so it checks for repository_group.name == "try".

Attached is what I see for non-try and try repos. The appearance looks fine to me.
Attachment #8511430 - Flags: review- → review?
Attachment #8511430 - Flags: review? → review?(emorley)
Comment on attachment 8511430 [details] [review]
Link to pull request 249

Looks good, thank you :-)
Attachment #8511430 - Flags: review?(emorley) → review+
This had bug 1075473 in the commit message, so the bot commented over there.

(In reply to Treeherder Bugbot from comment #2)
> Commits pushed to master at https://github.com/mozilla/treeherder-ui
> 
> https://github.com/mozilla/treeherder-ui/commit/94855c938516281d26c60ae84821375a388946f2
> Bug 1075473 - Hide the cancel all button for all repos that aren't in the
> try group.
> 
> https://github.com/mozilla/treeherder-ui/commit/e12443fad9c907e7938548516b440f6d86c72518
> Merge pull request #249 from KWierso/KILLCANCEL
> 
> Bug 1075473 - Hide the cancel all button for repos not in the 'try' group
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.