1089022 - Ask for a longer timeout for Android 2.3 conformance tests

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Give-WebGL-conformance-mochis-a-longer-timeout.patch

We're timing out extremely often on Android 2.3.
Let's extend its timeouts.

Comment 1

[u480271]

Comment on attachment 8511437 [details] [diff] [review]
0001-Give-WebGL-conformance-mochis-a-longer-timeout.patch

Review of attachment 8511437 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/test/webgl-conformance/mochi-single.html
@@ +246,5 @@
>  
> +var isAndroid2_3 = (DriverInfo.getOS() == DriverInfo.OS.ANDROID &&
> +                    DriverInfo.getOSVersion() < OS_VERSION_ANDROID_ICS);
> +if (isAndroid2_3) {
> +  SimpleTest.requestLongerTimeout(2);

What does the magic 2 mean?

Comment 2

[Kelsey Gilbert [:jgilbert]]

(In reply to Dan Glastonbury :djg :kamidphish from comment #1)
> Comment on attachment 8511437 [details] [diff] [review]
> 0001-Give-WebGL-conformance-mochis-a-longer-timeout.patch
> 
> Review of attachment 8511437 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/canvas/test/webgl-conformance/mochi-single.html
> @@ +246,5 @@
> >  
> > +var isAndroid2_3 = (DriverInfo.getOS() == DriverInfo.OS.ANDROID &&
> > +                    DriverInfo.getOSVersion() < OS_VERSION_ANDROID_ICS);
> > +if (isAndroid2_3) {
> > +  SimpleTest.requestLongerTimeout(2);
> 
> What does the magic 2 mean?

Good point. It's a multiple for the standard timeout time. `2` gives us twice as long of a timeout.

Comment 3

[Kelsey Gilbert [:jgilbert]]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/b78755143fda

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Give-WebGL-conformance-mochis-a-longer-timeout.patch

r=kamidphish

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b78755143fda

Comment 6

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8512344 [details] [diff] [review]
0001-Give-WebGL-conformance-mochis-a-longer-timeout.patch

Approval Request Comment
[Feature/regressing bug #]: unknown
[User impact if declined]: WebGL 2.3 android tests have high intermittence.
[Describe test coverage new/current, TBPL]: none
[Risks and why]: No user-facing risk.
[String/UUID change made/needed]: none

This is purely to make our tree greener.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8512344 [details] [diff] [review]
0001-Give-WebGL-conformance-mochis-a-longer-timeout.patch

Test-only changes don't need approval.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a56669d236e7
https://hg.mozilla.org/releases/mozilla-beta/rev/9a6a63827c10

I'm not convinced this is actually helping, though. I think we may want to split mochitest-gl into 2 chunks as our next option.

Comment 9

[Kelsey Gilbert [:jgilbert]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #8)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/a56669d236e7
> https://hg.mozilla.org/releases/mozilla-beta/rev/9a6a63827c10
> 
> I'm not convinced this is actually helping, though. I think we may want to
> split mochitest-gl into 2 chunks as our next option.

It certainly seems that way.

Comment 10

[Geoff Brown [:gbrown]]

(In reply to Jeff Gilbert [:jgilbert] from comment #9)
> (In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #8)
> > I'm not convinced this is actually helping, though. I think we may want to
> > split mochitest-gl into 2 chunks as our next option.
> 
> It certainly seems that way.

+1 :)

"application ran for longer than allowed maximum time" means that the test job (mochitest-gl) ran for longer than the maximum time (typically 1 hour). Even when green, Android 2.3 mochitest-gl is running for about an hour now. It is time for 2 chunks.

Comment 11

[Kelsey Gilbert [:jgilbert]]

Ah, ok. Let the chunking begin. That is bug 1093867.