Closed Bug 1089022 Opened 5 years ago Closed 5 years ago

Ask for a longer timeout for Android 2.3 conformance tests

Categories

(Core :: Canvas: WebGL, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36
Tracking Status
firefox34 --- fixed
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

Attachments

(1 file, 1 obsolete file)

We're timing out extremely often on Android 2.3.
Let's extend its timeouts.
Attachment #8511437 - Flags: review?(dglastonbury)
Blocks: 1087204
Blocks: 1078169
Blocks: 1085242
Blocks: 1081910
Blocks: 1089414
Blocks: 1085236
Blocks: 1084265
Blocks: 1088696
Blocks: 1088649
Blocks: 1081878
Blocks: 1086160
Blocks: 1062512
Blocks: 1066230
Comment on attachment 8511437 [details] [diff] [review]
0001-Give-WebGL-conformance-mochis-a-longer-timeout.patch

Review of attachment 8511437 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/test/webgl-conformance/mochi-single.html
@@ +246,5 @@
>  
> +var isAndroid2_3 = (DriverInfo.getOS() == DriverInfo.OS.ANDROID &&
> +                    DriverInfo.getOSVersion() < OS_VERSION_ANDROID_ICS);
> +if (isAndroid2_3) {
> +  SimpleTest.requestLongerTimeout(2);

What does the magic 2 mean?
Attachment #8511437 - Flags: review?(dglastonbury) → review+
(In reply to Dan Glastonbury :djg :kamidphish from comment #1)
> Comment on attachment 8511437 [details] [diff] [review]
> 0001-Give-WebGL-conformance-mochis-a-longer-timeout.patch
> 
> Review of attachment 8511437 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/canvas/test/webgl-conformance/mochi-single.html
> @@ +246,5 @@
> >  
> > +var isAndroid2_3 = (DriverInfo.getOS() == DriverInfo.OS.ANDROID &&
> > +                    DriverInfo.getOSVersion() < OS_VERSION_ANDROID_ICS);
> > +if (isAndroid2_3) {
> > +  SimpleTest.requestLongerTimeout(2);
> 
> What does the magic 2 mean?

Good point. It's a multiple for the standard timeout time. `2` gives us twice as long of a timeout.
r=kamidphish
Attachment #8511437 - Attachment is obsolete: true
Attachment #8512344 - Flags: review+
Blocks: 1084359
Blocks: 1081091
Blocks: 1062370
https://hg.mozilla.org/mozilla-central/rev/b78755143fda
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Blocks: 1076799
Blocks: 1089415
Blocks: 1090337
Blocks: 1087226
Comment on attachment 8512344 [details] [diff] [review]
0001-Give-WebGL-conformance-mochis-a-longer-timeout.patch

Approval Request Comment
[Feature/regressing bug #]: unknown
[User impact if declined]: WebGL 2.3 android tests have high intermittence.
[Describe test coverage new/current, TBPL]: none
[Risks and why]: No user-facing risk.
[String/UUID change made/needed]: none

This is purely to make our tree greener.
Attachment #8512344 - Flags: approval-mozilla-beta?
Attachment #8512344 - Flags: approval-mozilla-aurora?
Blocks: 1087302
Blocks: 1079619
Comment on attachment 8512344 [details] [diff] [review]
0001-Give-WebGL-conformance-mochis-a-longer-timeout.patch

Test-only changes don't need approval.
Attachment #8512344 - Flags: approval-mozilla-beta?
Attachment #8512344 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/releases/mozilla-aurora/rev/a56669d236e7
https://hg.mozilla.org/releases/mozilla-beta/rev/9a6a63827c10

I'm not convinced this is actually helping, though. I think we may want to split mochitest-gl into 2 chunks as our next option.
Blocks: 1088653
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #8)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/a56669d236e7
> https://hg.mozilla.org/releases/mozilla-beta/rev/9a6a63827c10
> 
> I'm not convinced this is actually helping, though. I think we may want to
> split mochitest-gl into 2 chunks as our next option.

It certainly seems that way.
Blocks: 1074581
Blocks: 1075458
Blocks: 1082482
Blocks: 1092201
(In reply to Jeff Gilbert [:jgilbert] from comment #9)
> (In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #8)
> > I'm not convinced this is actually helping, though. I think we may want to
> > split mochitest-gl into 2 chunks as our next option.
> 
> It certainly seems that way.

+1 :)

"application ran for longer than allowed maximum time" means that the test job (mochitest-gl) ran for longer than the maximum time (typically 1 hour). Even when green, Android 2.3 mochitest-gl is running for about an hour now. It is time for 2 chunks.
See Also: → 1093867
Ah, ok. Let the chunking begin. That is bug 1093867.
Blocks: 1082574
You need to log in before you can comment on or make changes to this bug.