lockscreen.locked should be set to false when FTU is launched

RESOLVED DUPLICATE of bug 1098997

Status

Firefox OS
Gaia::First Time Experience
RESOLVED DUPLICATE of bug 1098997
3 years ago
3 years ago

People

(Reporter: dhylands, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
The lockscreen.locked setting is used by the AdbController to determine if the phone is locked or not. On user/production builds this is used to control whether ADB is enabled or not.

After flashing a full image, lockscreen.locked is reported to be true, even though the phone isn't actually locked (the FTU app is running).

Once the phone is locked for the first time after the FTU app runs, then everything gets back into sync.

This causes the ADB setting in the Settings app to be ignored, because the AdbController believes the phone to be locked.

This is responsible for the behaviour reported in bug 1084955 comment 16 thru 20
Alive, I can go ahead and toggle this setting but the description makes me wonder if this is the right way to solve the problem. Inferring whether ADB is enabled from the value of this setting seems overloaded. In either case, the system app seems the right place to set this initial value (in FtuLauncher?) not the FTU app itself, so I would appreciate your input.
Flags: needinfo?(alive)
(Reporter)

Comment 2

3 years ago
Adb uses lockscreen.locked as one (of many inputs) to determine whether adb should be enabled.

It was considered to be a security issue to allow adb to be enabled when the phone is locked, which is why this is considered. It's been that way since 1.0 (for production builds)
This is a regression coming from lockscreenWindowManager refactoring.
Set lockscreen.lock is the responsibility of LWM,
And I think Greg had a fix.
Flags: needinfo?(alive) → needinfo?(gweng)
Yes, I think the patch of Bug 1086175 has fixed this (10/26). I may verify this later.
Flags: needinfo?(gweng)
We're tracking this for 2.1 in bug 1088157. The work for 2.2/master is in bug 1098997, I'm duping to that.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1098997
You need to log in before you can comment on or make changes to this bug.