Invalid mochitests skipped in dom/encoding/test/mochitest.ini

RESOLVED FIXED in mozilla36

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jgilbert, Assigned: vaibhav1994)

Tracking

(Blocks: 1 bug)

unspecified
mozilla36
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
> 16:07:15     INFO -  Warning: test_BOMEncoding.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_TextDecoder.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_TextEncoder.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/mochitest.ini is not a valid test
(Assignee)

Comment 1

3 years ago
Created attachment 8514349 [details] [diff] [review]
manifest.patch

Try push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5eb57dcac4ad
(Assignee)

Comment 2

3 years ago
Comment on attachment 8514349 [details] [diff] [review]
manifest.patch

Try push is green and warnings not present for the above tests. :jmaher, adding you as the reviewer.
Attachment #8514349 - Flags: review?(jmaher)
Comment on attachment 8514349 [details] [diff] [review]
manifest.patch

Review of attachment 8514349 [details] [diff] [review]:
-----------------------------------------------------------------

awesome, thanks!
Attachment #8514349 - Flags: review?(jmaher) → review+
(Assignee)

Updated

3 years ago
Assignee: nobody → vaibhavmagarwal
Keywords: checkin-needed
needs rebasing i guess

Hunk #1 FAILED at 3
1 out of 1 hunks FAILED -- saving rejects to file dom/encoding/test/mochitest.ini.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh manifest4.patch
Keywords: checkin-needed
(Assignee)

Comment 5

3 years ago
Created attachment 8514944 [details] [diff] [review]
manifest4.patch

Fixed for bitrot.
Attachment #8514349 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/8eafdf1f34ec
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8eafdf1f34ec
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.