Invalid mochitests skipped in dom/encoding/test/unit/mochitest.ini

RESOLVED FIXED in mozilla36

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jgilbert, Assigned: vaibhav1994)

Tracking

(Blocks: 1 bug)

unspecified
mozilla36
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
> 16:07:15     INFO -  Warning: test_big5.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/unit/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_euc-jp.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/unit/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_euc-kr.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/unit/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_gbk.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/unit/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_iso-2022-jp.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/unit/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_shift_jis.js from manifest /builds/slave/test/build/tests/mochitest/tests/dom/encoding/test/unit/mochitest.ini is not a valid test
(Assignee)

Comment 2

4 years ago
Created attachment 8514417 [details] [diff] [review]
manifest.patch

The jobs are green and no warnings for above tests. :jmaher, please review this too!
Attachment #8514307 - Attachment is obsolete: true
Attachment #8514417 - Flags: review?(jmaher)
Comment on attachment 8514417 [details] [diff] [review]
manifest.patch

Review of attachment 8514417 [details] [diff] [review]:
-----------------------------------------------------------------

i am concerned about this one, but reducing the directory tree is a really good thing.

Have you verified that dom/encoding tests all run with this patch?
Attachment #8514417 - Flags: review?(jmaher) → review+
(Assignee)

Comment 4

4 years ago
Yes the number of tests run are the same. This directory is run on chunk 2 of linux.
Comparing https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=2bef064321aa and https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1c0d59cc20bb, we see that the number of tests ( 266683/0/24276 ) is the same. Also, :ted commented in https://bugzilla.mozilla.org/show_bug.cgi?id=983867#c7 regarding removing the files, so I think this seems reasonable.
(Assignee)

Updated

4 years ago
Assignee: nobody → vaibhavmagarwal
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a9e7f26a5021
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.