1089138 - Parallel build fails with VS2013, need -FS option

Status: RESOLVED FIXED

(Directory :: LDAP C SDK, defect)

Description

[Stefan Sitter [:ssitter]]

From Bug 1085767 Comment 3:

> c:/builds/moz2_slave/tb-try-c-cen-w32-0000000000000/build/ldap/sdks/c-sdk/ldap/libraries/libldap/whoami.c : 
> fatal error C1041: cannot open program database 
> 'c:\builds\moz2_slave\tb-try-c-cen-w32-0000000000000\build\objdir-tb\ldap\sdks\c-sdk\ldap\libraries\libldap\vc120.pdb'; 
> if multiple CL.EXE write to the same .PDB file, please use /FS

That error was fairly straightforward on the FF side. You'll need some variant of bug 915973.

Comment 1

[Mark Banner (:standard8)]

The LDAP repository is here, we pull it in automatically:

https://hg.mozilla.org/projects/ldap-sdks/

Comment 2

[Kent James (:rkent)]

The /FS option is described here: http://msdn.microsoft.com/en-us/library/dn502518.aspx

Comment 3

[Joshua Cranmer [:jcranmer]]

An alternative option I tried playing with was just building LDAP with -j1. It's a small repo, so the loss of parallelization is negligible, and it avoids having to patch LDAP's configure.

Comment 4

[Stefan Sitter [:ssitter]]

Attachment: ldap-disable-parallel-build

Based on the previous comment I'm currently using this workaround that enforces non-parallel build for ldap. On my local system I can successfully build Thunderbird and SeaMonkey using VS2013 and mk_add_options MOZ_MAKE_FLAGS=-j4 in my mozconfig. Maybe you can test it with the official builders.

Comment 5

[[e-mail]]

Comment on attachment 8520721 [details] [diff] [review]
ldap-disable-parallel-build

Seems to me that this is overkill, surely you only need to unparallelise libs?

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Attachment: not parallel only for libs target

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Attachment: Add -FS option on VS2013

Comment 8

[Hiroyuki Ikezoe (:hiro)]

I have no VS2013 so I can't confirm either of patches work fine. But anyway we need to migrate VS2013 as soon as possible because comm-central tree is now broken. See bug 1105729.

Comment 9

[Joshua Cranmer [:jcranmer]]

(In reply to [e-mail] from comment #5)
> Comment on attachment 8520721 [details] [diff] [review]
> ldap-disable-parallel-build
> 
> Seems to me that this is overkill, surely you only need to unparallelise
> libs?

IIRC, the C-SDK does something weird and actually builds during export or something like that.

Comment 10

[Edmund Wong (:ewong)]

Comment on attachment 8530071 [details] [diff] [review]
Add -FS option on VS2013

fwiw, this works.

Comment 11

[Stefan Sitter [:ssitter]]

Could we get decision which one of the patches should be taken for check-in?

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

> +          dnl VS2013+ requires -FS when parallel building by make -jN.
> +          dnl If nothing, compiler sometimes causes C1041 error.
Seems like there is something missing in the first part of the second sentence.

Comment 13

[Stefan Sitter [:ssitter]]

VS2010 support will be dropped soon with Bug 1084532. Please decide if you want to take the patch for comm-central repository or if you want to take the patch for ldap-sdks repository.

Comment 14

[Magnus Melin [:mkmelin]]

^^^

Comment 15

[Joshua Cranmer [:jcranmer]]

(In reply to Stefan Sitter from comment #13)
> VS2010 support will be dropped soon with Bug 1084532. Please decide if you
> want to take the patch for comm-central repository or if you want to take
> the patch for ldap-sdks repository.

I'd prefer the comm-central repository, in part because I have no idea whom is the owner of the LDAP C-SDK stuff.

Comment 16

[Patrick Cloke [:clokep]]

attachment 8520721 [details] [diff] [review] landed as https://hg.mozilla.org/comm-central/rev/673f3227b36a

Comment 17

[Stefan Sitter [:ssitter]]

Resolving fixed per previous comment.

Comment 18

[Kent James (:rkent)]

Comment on attachment 8520721 [details] [diff] [review]
ldap-disable-parallel-build

I'd like to push this patch to comm-esr31 so that esr31 will also build with VS2013. Any comments or objections?

Comment 19

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8520721 [details] [diff] [review]
ldap-disable-parallel-build

Review of attachment 8520721 [details] [diff] [review]:
-----------------------------------------------------------------

None from me.