1089459 - [Settings] Performance regression on bug 1066830

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

Calling to mozApps.mgmt.getAll in the init function leads to performance regression. We should consider move the call to the callback of an idle observer.

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

[Blocking Requested - why for this release]: We should fix the performance regression.

Comment 2

[howie [:howie]]

Triage: perf regression blocking.

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on v2.1

Arthur, in this patch, I postpone the init() timing on root/panel.js and in this way, we can make sure the initializing work would only be done after idling for 4s.

And for master, I already filed another bug 1086167 which would remove all places using mgmt.getAll(), so for this bug, only 2.1 patch would be included.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

For master, I will fix it on bug 1086167 (I already filed this bug to track this work 1 week earlier, so let's track there).

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8514822 [details] [review]
patch on v2.1

r=me, thanks!

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8514822 [details] [review]
patch on v2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Performance statistics would be a little bit bad on Datazilla
[Testing completed]: Related codes have its own tests already, in this patch, we just postpone the initialization timing.
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: no

For master, because we already have new cache mechanism to reduce performance problems, I would fix it on another bug and please check "See also" field about it.

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Merged on v2.1: https://github.com/mozilla-b2g/gaia/commit/8b0cf889ae0d48a9eb7ecdcb9b67590de45cc5e5

Thanks all !

Comment 8

[Yeojin Chung [:YeojinC]]

Unable to verify as it is a back-end issue.

Comment 9

[Shally Li（leave from Mozilla）]

Hi,
    This bug has been verified successfully on Flame v2.1.
    See attachment: verified_v2.1.MP4
    Reproducing rate: 0/5

Flame 2.1 version:
Gaia-Rev        8ae086c39011bc8842b2a19bb5267906fa22345a
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebbd5c65c3c1
Build-ID        20141124094013
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141124.130744
FW-Date         Mon Nov 24 13:07:55 EST 2014
Bootloader      L1TC00011880

Comment 10

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.1.mp4