[Smart Screen][Home]Launch card directly from smart home

RESOLVED FIXED in 2.1 S8 (7Nov)

Status

Firefox OS
Gaia
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dwi2, Assigned: dwi2)

Tracking

unspecified
2.1 S8 (7Nov)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
This is a follow up of bug 1076706. Because bug 1076706 depends on bug 1076702, which need some non-trivial effort to integrate card launching into home app. This bug will actually implement 'launch' behavior of card.
(Assignee)

Comment 1

4 years ago
Created attachment 8515847 [details] [review]
pull request

Hi Rex,

With this patch, we could directly launch app from Smart home app now. I also add some unit test to make sure we correctly load card list as expected.

Please help to review the patch. Thanks
Attachment #8515847 - Flags: review?(rexboy)
Comment on attachment 8515847 [details] [review]
pull request

It's ok to land this patch. please see comments on Github first.

Thanks for your work!
Attachment #8515847 - Flags: review?(rexboy) → review+
(Assignee)

Updated

4 years ago
Assignee: nobody → tzhuang
(Assignee)

Comment 3

4 years ago
All comments are addressed. Waiting for Gaia-Try result https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=0c8ae6e440f8
(Assignee)

Comment 4

4 years ago
(In reply to Tzu-Lin Huang [:dwi2][:tzhuang] from comment #3)
> All comments are addressed. Waiting for Gaia-Try result
> https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=0c8ae6e440f8

Gaia-Try result should be this one https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=7a048182aeea
(Assignee)

Updated

4 years ago
Whiteboard: [ft:conndevices]
Target Milestone: --- → 2.1 S8 (7Nov)
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.