1089537 - In the Japanese, MDN Top Header link has broken.

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Localization, defect)

Description

[Mantaroh Yoshinaga(Main account is [e-mail])]

Steps to reproduce:

1. Open MDN Top page: https://developer.mozilla.org/ja/
  (browser locale setting is japanese)
2. Click on "App センター"(meaning "App Center" in japanese) link that displayed top site.

Expected results:
move to "App Center" in Japanese(/ja/docs/Web/Apps)

Actual results:
move to "App Center" in English(/en-US/Apps)

Same Problem in MDN Top Header Links:
Category[ZONE]
"Firefox"  (/en-US/Firefox   ->  /ja/docs/Mozilla/Firefox)
"FirefoxOS" (/en-US/Firefox_OS  ->  /ja/Firefox_OS)
"Persona"   (/en-US/Persona   ->  /ja/docs/Mozilla/Persona)

Comment 1

[Jean-Yves Perrier [:teoli]]

I think this is a bug on the dev side.

Comment 2

[Māris Fogels [:mars] (please needinfo)]

Almost all of the links across the top of the JA site are doing this.

:groovecoder, any idea what's going on here?

Comment 3

[Mantaroh Yoshinaga(Main account is [e-mail])]

I challenged to other languages.
 * zh-CH 
 * Italiano 
 * Deutsch..

Actual result is same(moved to /en-US sites).

Comment 4

[Jean-Yves Perrier [:teoli]]

That's the usual zone problem.

Comment 5

[Jean-Yves Perrier [:teoli]]

Oops, forget my last comment, looked at the wrong thing.

Comment 6

[John Karahalis [:openjck]]

Luke and I investigated this today. There are two things we probably need to change to address this bug.

1. The devmo_url helper does not appear to work with Zones. It sometimes returns
   the URL of an English document even when the document does exist in the
   currently-loaded locale.

2. We now have a feature where, if a document does not exist in the current
   locale, the English document will be loaded and a message will be shown at the
   top of the page explaining this and encouraging the person to localize the
   document. Because we have this fallback, we can probably modify devmo_url to
   return the current-locale version of a document no matter what.

Comment 8

[Nayuta Ishii]

Hi luke,

I'd checked 'mozilla/kuma' repository. If its master branch is released, logics for links these pages is already corrected.

I think you can modify data and refresh cash to correct this.

Or, how can I do it?

Comment 9

[Luke Crouch [:groovecoder]]

The master branch is already released. (https://whatsdeployed.paas.allizom.org/?owner=mozilla&repo=kuma&name[]=Stage&url[]=https://developer.allizom.org/media/revision.txt&name[]=Prod&url[]=https://developer.mozilla.org/media/revision.txt)

What link logic are you looking at? Is it the "devmo_url" helper? I think that's where we would need to fix this.

-L

Comment 10

[Nayuta Ishii]

Hi Luke,

"wiki_url" is used. This is expected implementation I think. Is this correct?

I think it caused by contents cache or wiki contents.

https://github.com/mozilla/kuma/blob/f8b9f86de4206b84eadc007d219fdc08adb72220/kuma/landing/templates/landing/homepage.html

Or, other server architecture problem.

Comment 11

[Luke Crouch [:groovecoder]]

Yoshinaga, Nayuta, yes there's a bug in the wiki_url helper - it does not find Document "Zones" when it checks for localized documents to create the link. (See https://bugzilla.mozilla.org/show_bug.cgi?id=1154417#c3 and https://bugzilla.mozilla.org/show_bug.cgi?id=1154417#c7)

If you'd like to try fixing wiki_url to work with DocumentZone objects' url mapping that would be great. But it might be a complicated area of the code.

I've got this bug in our Inbox [1] so I'm going to try to fix it this week, but we've got some other changes in front of it, too. [2]

[1] https://trello.com/b/p56Gwq46/mdndev-rocks
[2] https://github.com/mozilla/kuma/pulls

Comment 12

[Julien G]

If this can help: this is also reproduced for the fr locale in the "zones" dropdown menu which is on the home page (issue with links for Apps, Firefox, Persona (others are OK))

Comment 13

[Masahiko Imanaka [:marsf]]

I've tried to fix redirect URL of the Firefox OS page, it seems be looped.
Is it effective?

https://developer.mozilla.org/ja/docs/Firefox_OS$compare?locale=ja&to=791931&from=564787

Comment 14

[Nayuta Ishii]

With reading source code, there is nothing seems to bug...

If it is cleared this is not caused by cache, old url cached by memcache, it is only way to I'll build my build environment and write test like that https://github.com/mozilla/kuma/blob/master/kuma/wiki/tests/test_helpers.py .

Or any ideas?

Comment 15

[Luke Crouch [:groovecoder]]

We discussed this on Friday during our product meeting. Everyone agrees we need to do something with zones + locales, but we're not sure what to do yet. :(

https://bugzilla.mozilla.org/show_bug.cgi?id=1158239 is the meta bug for it, and we'll try to work out a product-level plan for zones and then decide if we should 1. fix these translated zone navigation issues or 2. remove/replace the zone features completely

Comment 16

[Luke Crouch [:groovecoder]]

Note: today we pushed new MDN header link behavior. I just checked all the /ja/ and /zh-CN/ Zones links, and they all seem to stick in the /ja/ docs now, *except* for the Firefox zone.

:teoli - can you tell if there's something "special" about the Firefox zone that it's still broken?

Mantaroh - does the new behavior work better for you?

Comment 17

[Mantaroh Yoshinaga(Main account is [e-mail])]

Hi groovecoder,

I confirmed each zone.
"アドオン"(mean Add-on)        -> /ja/docs/Mozilla/Add-ons
"アプリセンター"(mean AppCenter) -> /ja/Apps
"Firefox"                    -> /en-US/Firefox (expected /ja/Firefox)
"Firefox Marketplace"        -> /ja/Marketplace
"Firefox OS"                 -> /ja/Firefox_OS
"Persona"                    -> /ja/docs/Mozilla/Persona

This behavior was same as my expected result.(except 'Firefox' zone.)
Thank you so much.

Comment 18

[Jean-Yves Perrier [:teoli]]

Luke: no, nothing special for the Firefox zone. It is a plain regular zone (AFAIK).

Comment 19

[John Whitlock [:jwhitlock]]

Zones have been removed (bug 1462475), so no remaining special zone behavior. 

With the move the MDN Web Docs, Firefox links have been removed. These links are a history lesson in cancelled projects.

https://developer.mozilla.org/ja/Firefox now redirects to https://developer.mozilla.org/ja/docs/Mozilla/Firefox.