1089598 - yahoo search code for the search activity widget

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Karen Rudnitski [:kar]]

Please use the following search code for the Search Activity widget for Yahoo: mozilla_mobile2_search 

Please uplift this ASAP to beta to match where Yahoo is currently showing as default in en-US

Comment 1

[Mike Connor [:mconnor]]

The correct fr value for that tag is mozmob2, not mozilla_mobile2_search.

Karen, I assume the goal here is to split out traffic/revenue for SA searches?

Comment 2

[:Margaret Leibovic]

I can write a patch once I get confirmation from mconnor about what we need to change.

Comment 3

[:Margaret Leibovic]

(In reply to Karen Rudnitski [:kar] from comment #0)

> Please uplift this ASAP to beta to match where Yahoo is currently showing as
> default in en-US

The search activity is only in aurora, so we only need to uplift this there.

Comment 4

[Karen Rudnitski [:kar]]

Margaret - thanks, so only aurora :)

Joanne - please see mconnor's thoughts on the search code yahoo sent over. Can you please circle back to Yahoo? :/

Comment 5

[Joanne Nagel]

I've already sent email and I'm waiting for confirmation (my contact was out sick yesterday); hoping for an update today.

Comment 6

[Joanne Nagel]

Ok, Yahoo has confirmed the use of:  mozmob2  for the widget.

Comment 7

[:Margaret Leibovic]

Attachment: Yahoo search code for the search activity widget

I feel kinda dirty about this, but this is the easiest way to distinguish a search activity search given our current code. I feel like I should update rel="mobile" to be rel="searchactivity" or something like that, but that would require updating the wikipedia plugin as well.

Also, we'll need to update other locales as well, right?

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8514526 [details] [diff] [review]
Yahoo search code for the search activity widget

Can you file a bug to switch over to use rel="mobile|tablet|search", because it seems like a the best way forward. We can work on that once the dust settles on all the search provider stuff.

Comment 9

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/76297cb7a06f

Comment 10

[:Margaret Leibovic]

Comment on attachment 8514526 [details] [diff] [review]
Yahoo search code for the search activity widget

Approval Request Comment
[Feature/regressing bug #]: search activity v1 (shipping in Fx35)
[User impact if declined]: Yahoo can't distinguish where searches come from
[Describe test coverage new/current, TBPL]: tested locally
[Risks and why]: low-risk, changes a search parameter
[String/UUID change made/needed]: none

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/76297cb7a06f

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ff4f45257692