1089655 - crash in java.lang.RuntimeException: Unhandled error for GeckoRequest: FindInPage:Find at org.mozilla.gecko.util.GeckoRequest.onError(GeckoRequest.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-1496792f-f78b-481f-8d18-65c5a2141026.
=============================================================

java.lang.RuntimeException: Unhandled error for GeckoRequest: FindInPage:Find
	at org.mozilla.gecko.util.GeckoRequest.onError(GeckoRequest.java:89)
	at org.mozilla.gecko.GeckoAppShell$4.handleMessage(GeckoAppShell.java:436)
	at org.mozilla.gecko.EventDispatcher.dispatchEvent(EventDispatcher.java:168)
	at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:2348)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:369)
	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:190)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Looking at the callstack, this could be a problem in the FindHelper.js code. Messaging.jsm says the addListener call must return an object. It looks like the "finder" listener.onMatchesCountResult is always passed an object:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/FindHelper.js#99

Which is then used as a return to the GeckoRequest:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/FindHelper.js#37

Sadly, no logcat in any of the crash reports yet. If anyone can reproduce this, please get a good logcat.

Comment 2

[Mark Capella [:capella]]

Attachment: bug1089655.diff

I haven't run into issues during my own use, but in either case...

I have an unrelated patch in my queue where I use Java->JS messaging in SelectionHandler code and I've had to provide a bit like the attached...

Comment 3

[Mark Capella [:capella]]

Comment on attachment 8514462 [details] [diff] [review]
bug1089655.diff

Never cast your reviews to the wind :/

Comment 4

[Mark Capella [:capella]]

try server
https://tbpl.mozilla.org/?tree=Try&rev=e65849b0c0fb

Comment 5

[Mark Capella [:capella]]

https://hg.mozilla.org/integration/fx-team/rev/44161bd0f41c

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/44161bd0f41c