1089718 - [music] Make the metadata parser sane

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Jim Porter (:squib)]

In the interests of maintainability (and some easy startup perf improvements), we should clean up the music metadata parser. This means: cleaning up the code style, splitting it out into multiple (lazy-loaded) files, using Promises where possible, and probably a few other things as I think of them.

Comment 1

[Jim Porter (:squib)]

Attachment: Pull request

Still WIP, but I've already reduced metadata.js by almost 50% in size.

Comment 2

[Jim Porter (:squib)]

Comment on attachment 8512271 [details] [review]
Pull request

Ok, I think this is done. Sorry for making another huge metadata patch, but this should be the last time I need to do any big rewrites, since everything's now safely nestled in separate files.

Comment 3

[David Flanagan [:djf]]

Comment on attachment 8512271 [details] [review]
Pull request

This looks like a really solid patch to me. I really like that each metadata format can be independently lazy loaded.  I've left a bunch of comments on github. Almost all are minor. I think I only found two real errors and I think you've already fixed those.

Comment 4

[Hubert Figuiere [:hub]]

Comment on attachment 8512271 [details] [review]
Pull request

Looks good to me. Nothing to add from David thorough reviewing.

Comment 5

[Jim Porter (:squib)]

Oops, I forgot to squash this before landing, so I kind of made a mess of things. Anyway, here's the squashed merge commit:

https://github.com/mozilla-b2g/gaia/commit/ace8153b0db6fa89f006f22f76ce338a258203c7