1089734 - Update "Report Site Issue" tab URL to https

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mike Taylor [:miketaylr]]

We now use HTTPS by default for webcompat.com, so this change updates the URL of the tab opened by "Report Site Issue".

Comment 1

[Mike Taylor [:miketaylr]]

Note, there's a 301 redirect from http to https and we're using HSTS... but we should just fix this at the source.

Comment 2

[Mike Taylor [:miketaylr]]

Attachment: 1089734.patch

Comment 3

[:Margaret Leibovic]

Comment on attachment 8512079 [details] [diff] [review]
1089734.patch

Review of attachment 8512079 [details] [diff] [review]:
-----------------------------------------------------------------

Also stealing this review from wesj!

Comment 4

[Mike Taylor [:miketaylr]]

Attachment: 1089734-2.patch

(changing r=wesj -> r=margaret)

Comment 5

[Carsten Book [:Tomcat]]

Hi Mike, patch failed to apply:

applying 1089734-2.patch
patching file mobile/android/chrome/content/WebcompatReporter.js
Hunk #1 FAILED at 70
1 out of 1 hunks FAILED -- saving rejects to file mobile/android/chrome/content/WebcompatReporter.js.rej

could you take a look? Thanks!

Comment 6

[Mike Taylor [:miketaylr]]

Hey Carsten, sorry about that. I think the problem was this patch was based off my branch which contained the patch in https://bugzilla.mozilla.org/show_bug.cgi?id=1089376. /o\

It should apply cleanly once https://hg.mozilla.org/integration/fx-team/rev/9d42e896570c lands on moz-central. Should I just add the checking-needed keyword again when that happens? Or would a new patch be better?

Comment 7

[Carsten Book [:Tomcat]]

> It should apply cleanly once
> https://hg.mozilla.org/integration/fx-team/rev/9d42e896570c lands on
> moz-central. Should I just add the checking-needed keyword again when that
> happens? Or would a new patch be better?

seems i just merged this over :) so re-setting checkin-needed again :) Thanks Mike!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/702187d1d5cb

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/702187d1d5cb

Comment 10

[Teodora Vermesan (:TeoVermesan)]

The URL displays "https", so:
Verified fixed on:
Device: LG Nexus 4 
OS: Android 4.4
Build: Firefox for Android 36.0a1 (2014-10-29)