Closed Bug 1089734 Opened 5 years ago Closed 5 years ago

Update "Report Site Issue" tab URL to https

Categories

(Firefox for Android :: General, defect)

x86
macOS
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 36
Tracking Status
fennec 36+ ---

People

(Reporter: miketaylr, Assigned: miketaylr)

Details

Attachments

(1 file, 1 obsolete file)

We now use HTTPS by default for webcompat.com, so this change updates the URL of the tab opened by "Report Site Issue".
Note, there's a 301 redirect from http to https and we're using HSTS... but we should just fix this at the source.
Attached patch 1089734.patch (obsolete) — Splinter Review
tracking-fennec: --- → ?
Comment on attachment 8512079 [details] [diff] [review]
1089734.patch

Review of attachment 8512079 [details] [diff] [review]:
-----------------------------------------------------------------

Also stealing this review from wesj!
Attachment #8512079 - Flags: review?(wjohnston) → review+
Assignee: nobody → miket
Attached patch 1089734-2.patchSplinter Review
(changing r=wesj -> r=margaret)
Attachment #8512079 - Attachment is obsolete: true
Keywords: checkin-needed
Hi Mike, patch failed to apply:

applying 1089734-2.patch
patching file mobile/android/chrome/content/WebcompatReporter.js
Hunk #1 FAILED at 70
1 out of 1 hunks FAILED -- saving rejects to file mobile/android/chrome/content/WebcompatReporter.js.rej

could you take a look? Thanks!
Flags: needinfo?(miket)
Hey Carsten, sorry about that. I think the problem was this patch was based off my branch which contained the patch in https://bugzilla.mozilla.org/show_bug.cgi?id=1089376. /o\

It should apply cleanly once https://hg.mozilla.org/integration/fx-team/rev/9d42e896570c lands on moz-central. Should I just add the checking-needed keyword again when that happens? Or would a new patch be better?
> It should apply cleanly once
> https://hg.mozilla.org/integration/fx-team/rev/9d42e896570c lands on
> moz-central. Should I just add the checking-needed keyword again when that
> happens? Or would a new patch be better?

seems i just merged this over :) so re-setting checkin-needed again :) Thanks Mike!
Flags: needinfo?(cbook)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/702187d1d5cb
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
The URL displays "https", so:
Verified fixed on:
Device: LG Nexus 4 
OS: Android 4.4
Build: Firefox for Android 36.0a1 (2014-10-29)
Status: RESOLVED → VERIFIED
tracking-fennec: ? → 36+
You need to log in before you can comment on or make changes to this bug.