1089770 - Need to get all answers to a question.

Status: RESOLVED FIXED

(support.mozilla.org :: Questions, task, P2)

Description

[Anthony Ricaud (:rik)]

To have a responsive application, we need to get all answers to a question in one request.

I think the cleanest API for this would be GET /question/{id}?full_content=1 or something similar.

Comment 1

[Michael Cooper [:mythmon]]

After some thought (and looking at some other APIs including GitHub's issue API) I think it would make sense to just include the content in the response all the time. Does that sound reasonable to you? Then to get all answers to a question you could make a GET to /api/2/answer/?question={id} and that would include everything you need to fill out the answers on a question detail page.

Do you see any problem with always including the full content?

Comment 2

[Anthony Ricaud (:rik)]

No, we will never query an answer without the content. I was thinking though that putting this API on the question endpoint will allow us to only do one HTTP request when a user opens a thread.

Comment 3

[Anthony Ricaud (:rik)]

We're going to go with /api/2/answer/?question={id}  that gives us the full content for now. It's one more request but that's not too bad and will make it much easier to implement server side.

Comment 4

[Michael Cooper [:mythmon]]

In a PR: https://github.com/mozilla/kitsune/pull/2194

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/2cf4aab3a677521d9815540c4891d92fd5da1d8f

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Mike did this in this sprint. Assuming 1pt

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod.