1089780 - Fix Moz2D recording on Linux

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[Nicolas Silva [:nical]]

Last time I checked there were a bunch of build failures with the recording feature on linux and the player, and a bunch of issues with the standalone moz2D repo not being always in sync with mozilla-central.

Those are mostly simple fixes and getting the recorder to work on lix would be awesome to help debugging some bugs like Bug 1033375.

Comment 1

[[e-mail]]

Attachment: fix_linux_compile_1.patch

Comment 2

[[e-mail]]

Attachment: fix_linux_compile_2.patch

Comment 3

[[e-mail]]

Attachment: fix_linux_compile_3.patch

Comment 4

[[e-mail]]

Attachment: fix_linux_compile_4.patch

Comment 5

[[e-mail]]

Attachment: fix_linux_compile_5.patch

Comment 6

[[e-mail]]

Attachment: fix_linux_compile_6.patch

Comment 7

[[e-mail]]

Attachment: fix_linux_compile_7.patch

Comment 8

[[e-mail]]

Attachment: add_hgignore.patch

Comment 9

[[e-mail]]

Patches fix_linux_compile_*.patch allow to build player2d. It was tested with clang++ and g++. There are a lot of warning, but we have not fixed them.

@Nicolas Silva: I think that the patch you sent me (fix_linux_compile_1.patch) needs to be merged with fix_linux_compile_6.patch

The patch add_hgignore.patch is not related with that bug. We created it during the creation of the others patches. Maybe, it can be useful.

Comment 10

[Bas Schouten (:bas.schouten)]

Maybe we should update the Moz2D stand-alone repo to inbound's latest version first? :S

Comment 11

[Nicolas Silva [:nical]]

(In reply to Bas Schouten (:bas.schouten) from comment #10)
> Maybe we should update the Moz2D stand-alone repo to inbound's latest
> version first? :S

Sure, how do you usually go about it, you just replace the content of the moz2d repo with whatever's in mozilla-inbound or is it a more involved process?

Comment 12

[mathieu.blot]

Attachment: export.sh

Bash script to qexport and qimport patchs (since the last shared commit) from mozilla-inbound to moz2d

Comment 13

[mathieu.blot]

Attachment: diff_cutter.rb

Ruby script to cut irrelevant diffs from the patchs.
Dependant with export.sh.

Comment 14

[mathieu.blot]

export.sh and diff_cutter.rb can help you (probably Bas) to update the moz2d repository from mozilla-inbound since it will automate the export and the export of patchs.
However, conflicts remain to be corrected by manual merge.
Furthermore, [e-mail] and me won't be working on this bug anymore.

Comment 15

[Nicolas Silva [:nical]]

Comment on attachment 8617770 [details]
export.sh

Thanks for the scripts. They won't be checked in mozilla-central so review/feedbacks aren't needed but it's useful to have them attached to this bug.

Comment 16

[Bas Schouten (:bas.schouten)]

Comment on attachment 8617770 [details]
export.sh

How do you real with conflicts?

Comment 17

[robin.moussu+github]

> How do you real with conflicts?

That's the best we can do with our understanding of the moz2d repository so far.