Fix Moz2D recording on Linux

NEW
Unassigned

Status

()

Core
Graphics
4 years ago
3 years ago

People

(Reporter: nical, Unassigned, Mentored)

Tracking

Trunk
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(10 attachments)

(Reporter)

Description

4 years ago
Last time I checked there were a bunch of build failures with the recording feature on linux and the player, and a bunch of issues with the standalone moz2D repo not being always in sync with mozilla-central.

Those are mostly simple fixes and getting the recorder to work on lix would be awesome to help debugging some bugs like Bug 1033375.
Created attachment 8609347 [details] [diff] [review]
fix_linux_compile_1.patch
Created attachment 8609348 [details] [diff] [review]
fix_linux_compile_2.patch
Created attachment 8609349 [details] [diff] [review]
fix_linux_compile_3.patch
Created attachment 8609350 [details] [diff] [review]
fix_linux_compile_4.patch
Created attachment 8609351 [details] [diff] [review]
fix_linux_compile_5.patch
Created attachment 8609352 [details] [diff] [review]
fix_linux_compile_6.patch
Created attachment 8609353 [details] [diff] [review]
fix_linux_compile_7.patch
Patches fix_linux_compile_*.patch allow to build player2d. It was tested with clang++ and g++. There are a lot of warning, but we have not fixed them.

@Nicolas Silva: I think that the patch you sent me (fix_linux_compile_1.patch) needs to be merged with fix_linux_compile_6.patch

The patch add_hgignore.patch is not related with that bug. We created it during the creation of the others patches. Maybe, it can be useful.
(Reporter)

Updated

3 years ago
Assignee: nobody → mathieu.blot
(Reporter)

Updated

3 years ago
Attachment #8609347 - Flags: review?(bas)
(Reporter)

Updated

3 years ago
Attachment #8609348 - Flags: review?(bas)
(Reporter)

Updated

3 years ago
Attachment #8609349 - Flags: review?(bas)
(Reporter)

Updated

3 years ago
Attachment #8609350 - Flags: review?(bas)
(Reporter)

Updated

3 years ago
Attachment #8609351 - Flags: review?(bas)
(Reporter)

Updated

3 years ago
Attachment #8609352 - Flags: review?(bas)
(Reporter)

Updated

3 years ago
Attachment #8609353 - Flags: review?(bas)
Maybe we should update the Moz2D stand-alone repo to inbound's latest version first? :S
(Reporter)

Comment 11

3 years ago
(In reply to Bas Schouten (:bas.schouten) from comment #10)
> Maybe we should update the Moz2D stand-alone repo to inbound's latest
> version first? :S

Sure, how do you usually go about it, you just replace the content of the moz2d repo with whatever's in mozilla-inbound or is it a more involved process?

Updated

3 years ago
Assignee: mathieu.blot → nobody

Comment 12

3 years ago
Created attachment 8617770 [details]
export.sh

Bash script to qexport and qimport patchs (since the last shared commit) from mozilla-inbound to moz2d
Attachment #8617770 - Flags: feedback?(nical.bugzilla)
Attachment #8617770 - Flags: feedback?(bas)

Comment 13

3 years ago
Created attachment 8617772 [details]
diff_cutter.rb

Ruby script to cut irrelevant diffs from the patchs.
Dependant with export.sh.
Attachment #8617772 - Flags: feedback?(nical.bugzilla)
Attachment #8617772 - Flags: feedback?(bas)

Comment 14

3 years ago
export.sh and diff_cutter.rb can help you (probably Bas) to update the moz2d repository from mozilla-inbound since it will automate the export and the export of patchs.
However, conflicts remain to be corrected by manual merge.
Furthermore, robin.moussu+git@gmail.com and me won't be working on this bug anymore.
(Reporter)

Comment 15

3 years ago
Comment on attachment 8617770 [details]
export.sh

Thanks for the scripts. They won't be checked in mozilla-central so review/feedbacks aren't needed but it's useful to have them attached to this bug.
Attachment #8617770 - Flags: feedback?(nical.bugzilla)
Attachment #8617770 - Flags: feedback?(bas)
(Reporter)

Updated

3 years ago
Attachment #8617772 - Flags: feedback?(nical.bugzilla)
Attachment #8617772 - Flags: feedback?(bas)
(Reporter)

Updated

3 years ago
Attachment #8609347 - Flags: review?(bas)
(Reporter)

Updated

3 years ago
Attachment #8609348 - Flags: review?(bas)
(Reporter)

Updated

3 years ago
Attachment #8609349 - Flags: review?(bas)
(Reporter)

Updated

3 years ago
Attachment #8609350 - Flags: review?(bas)
(Reporter)

Updated

3 years ago
Attachment #8609351 - Flags: review?(bas)
(Reporter)

Updated

3 years ago
Attachment #8609352 - Flags: review?(bas)
(Reporter)

Updated

3 years ago
Attachment #8609353 - Flags: review?(bas)
Comment on attachment 8617770 [details]
export.sh

How do you real with conflicts?
Attachment #8617770 - Flags: feedback+

Comment 17

3 years ago
> How do you real with conflicts?

That's the best we can do with our understanding of the moz2d repository so far.
You need to log in before you can comment on or make changes to this bug.