Closed Bug 1089810 Opened 10 years ago Closed 10 years ago

Update Private Browsing contextual hint string

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 36

People

(Reporter: liuche, Assigned: liuche)

References

Details

Attachments

(4 files, 2 obsolete files)

From the Private Browsing contextual hint bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1014293#c32

We should change the string to say:
"Psst: using a New Private Tab won't save your history."
Assignee: nobody → liuche
Attached patch Part 1: StringsSplinter Review
Attachment #8513589 - Flags: review?(margaret.leibovic)
Tweaking some layout changes too, esp for smaller devices - patch forthcoming.
Status: NEW → ASSIGNED
Comment on attachment 8513589 [details] [diff] [review]
Part 1: Strings

Review of attachment 8513589 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if you rev the entity name as well.

::: mobile/android/base/locales/en-US/android_strings.dtd
@@ +403,2 @@
>       The placeholders &formatS1; and &formatS2; are used to mark the location of text underlining. -->
> +<!ENTITY home_most_recent_emptyhint "Psst: using a &formatS1;New Private Tab&formatS2; won\'t save your history.">

We should rev the entity, since some localizers start working as soon as patches hit m-c.
Attachment #8513589 - Flags: review?(margaret.leibovic) → review+
Attached patch Part 2: Improved empty layout (obsolete) — Splinter Review
Adjusted the empty layouts so the views are more centered.
Attachment #8513931 - Flags: review?(michael.l.comella)
Attached patch Part 2: Improved empty layout (obsolete) — Splinter Review
Hey Lucas, we are back to empty layouts again! mcomella about this posed the question of whether there was some other way to do this layout without the two extra "spacer views". Simply centering the two views doesn't work because we want the empty layout to be higher than center (if there is space).

Here were a few things we considered:
- Adding extra margin to the bottom view. This is a little problematic because the bottom view is now the contextual hint, which is now "gone," so the padding may not always be present. This might also cut off the content on smaller screens.
- Adding a scrollview, and adding the bottom margin. This might cause screens to have a scrollview even if all the content can be squished on the screen - I didn't like it because it makes the empty view seem too heavy.

Anyways, could you think on this briefly, and let me know if you come up with any other solutions that don't need the two extra views? A RelativeLayout would be possible, but I'm not sure if it would cost less perf-wise than a LinearLayout with two weighted filler views.
Attachment #8513931 - Attachment is obsolete: true
Attachment #8513931 - Flags: review?(michael.l.comella)
Flags: needinfo?(lucasr.at.mozilla)
Attachment #8513966 - Flags: review?(michael.l.comella)
Comment on attachment 8513966 [details] [diff] [review]
Part 2: Improved empty layout

Moving this patch to bug 1091856 because :antlam was thinking about making some changes to the empty panels, clearing review and NI.
Attachment #8513966 - Attachment is obsolete: true
Flags: needinfo?(lucasr.at.mozilla)
Attachment #8513966 - Flags: review?(michael.l.comella)
https://hg.mozilla.org/integration/fx-team/rev/a77d5f0036f8
Target Milestone: --- → Firefox 36
https://hg.mozilla.org/mozilla-central/rev/a77d5f0036f8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified as fixed in
Build: Firefox for Android 36.0a1 (2014-11-02)
Device: Motorola Razr (Android 4.1.2)
Status: RESOLVED → VERIFIED
QA Contact: ioana.chiorean
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: