1089822 - Attempting to run reftest-remote on B2G fails

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

It's that time again, where I try to run some tests locally and fail miserably. I built B2G (KK emulator) like so:

  BRANCH=master ./config.sh emulator && ./build.sh

After some fiddling with libGL.so symlinks I got that working and attempted to run some reftests like so:

  ./mach reftest-remote gecko/layout/reftests/image/reftest.list

This results in the exception at [1] getting thrown. The error message says to pass in the --utility-path option, but of course |mach reftest-remote| accepts no such option, and errors out if I provide one anyway.

[1] http://mxr.mozilla.org/mozilla-central/source/layout/tools/reftest/runreftestb2g.py?rev=199775c34d69#360

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Workaround

Comment 2

[Botond Ballo [:botond]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #0)
> I built B2G (KK emulator) like so:
> 
>   BRANCH=master ./config.sh emulator && ./build.sh

If you built the KK emulator, wouldn't that have been './config.sh emulator-kk'?

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Yeah that's what I meant. But today I built "emulator" (i.e. emulator ICS) and had the same problem, so I don't think this issue is specific to the emulator version.

Comment 4

[Andrew Halberstadt [:ahal]]

Assuming the workaround doesn't break anything in production, I'd be fine taking it as is. I'll look into fixing that marionette.expected issue first, though no reason that needs to block this if someone else wants to do it.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=693aa9b4ddaf

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8534325 [details] [diff] [review]
Patch

Review of attachment 8534325 [details] [diff] [review]:
-----------------------------------------------------------------

That try push looks green enough

Comment 8

[Andrew Halberstadt [:ahal]]

Comment on attachment 8534325 [details] [diff] [review]
Patch

Review of attachment 8534325 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

For future reference, you could have pushed to try with -p emulator -u reftest in this case.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

(In reply to Andrew Halberstadt [:ahal] from comment #8)
> For future reference, you could have pushed to try with -p emulator -u
> reftest in this case.

I considered that but then I realized that I have no idea how any of this python stuff works and didn't feel confident that my change definitely wouldn't affect other platforms :)

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/60b4aefc4c0c

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/60b4aefc4c0c