Attempting to run reftest-remote on B2G fails

RESOLVED FIXED in mozilla37

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

unspecified
mozilla37
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

It's that time again, where I try to run some tests locally and fail miserably. I built B2G (KK emulator) like so:

  BRANCH=master ./config.sh emulator && ./build.sh

After some fiddling with libGL.so symlinks I got that working and attempted to run some reftests like so:

  ./mach reftest-remote gecko/layout/reftests/image/reftest.list

This results in the exception at [1] getting thrown. The error message says to pass in the --utility-path option, but of course |mach reftest-remote| accepts no such option, and errors out if I provide one anyway.

[1] http://mxr.mozilla.org/mozilla-central/source/layout/tools/reftest/runreftestb2g.py?rev=199775c34d69#360
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #0)
> I built B2G (KK emulator) like so:
> 
>   BRANCH=master ./config.sh emulator && ./build.sh

If you built the KK emulator, wouldn't that have been './config.sh emulator-kk'?
Yeah that's what I meant. But today I built "emulator" (i.e. emulator ICS) and had the same problem, so I don't think this issue is specific to the emulator version.
Assuming the workaround doesn't break anything in production, I'd be fine taking it as is. I'll look into fixing that marionette.expected issue first, though no reason that needs to block this if someone else wants to do it.
Created attachment 8534325 [details] [diff] [review]
Patch
Attachment #8533312 - Attachment is obsolete: true
Comment on attachment 8534325 [details] [diff] [review]
Patch

Review of attachment 8534325 [details] [diff] [review]:
-----------------------------------------------------------------

That try push looks green enough
Attachment #8534325 - Flags: review?(ahalberstadt)
Assignee: nobody → bugmail.mozilla
Comment on attachment 8534325 [details] [diff] [review]
Patch

Review of attachment 8534325 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

For future reference, you could have pushed to try with -p emulator -u reftest in this case.
Attachment #8534325 - Flags: review?(ahalberstadt) → review+
(In reply to Andrew Halberstadt [:ahal] from comment #8)
> For future reference, you could have pushed to try with -p emulator -u
> reftest in this case.

I considered that but then I realized that I have no idea how any of this python stuff works and didn't feel confident that my change definitely wouldn't affect other platforms :)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/60b4aefc4c0c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.