Closed
Bug 1089855
Opened 8 years ago
Closed 8 years ago
remove config/module2dir.pl
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
2.82 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
grep indicates that it's not used anywhere in the tree, and it's not obvious from the documentation within what it was ever used for.
![]() |
Assignee | |
Comment 1•8 years ago
|
||
Less perl in the tree can't be a bad thing.
Attachment #8512243 -
Flags: review?(mshal)
Comment 2•8 years ago
|
||
Comment on attachment 8512243 [details] [diff] [review] remove config/module2dir.pl Review of attachment 8512243 [details] [diff] [review]: ----------------------------------------------------------------- Since I've done the research on this one already. It has never been used by the build system itself since it was added in 2001 [1]. It used to contain a manual list of modules until 2003 [2] at which point it reused the data generated from tools/module-deps, which depended on MODULE and REQUIRES data in Makefile.in, the former or which went away last year [3] ; the latter were removed in 2009 [4]. The interesting thing is that tools/module-deps was lost during the transition to mercurial: it's not in revision 1, but it's in the last revision on CVS. IOW, module2dir.pl has been useless since 2008. 1. https://github.com/mozilla/gecko-dev/commit/40df708da9f0f8594a6feee97c35c36b44be06fb 2. https://github.com/mozilla/gecko-dev/commit/d7aca2a1bbfd2185067412fe64e1d85c2e697fdc 3. https://github.com/mozilla/gecko-dev/commit/7ecea60097858b273f031790fb3e90af5346f9f3 4. https://github.com/mozilla/gecko-dev/commit/36bc86429d0e3c0c0854a94bbef6275c39d671ea
Attachment #8512243 -
Flags: review?(mshal) → review+
Comment 3•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/470d48fa537a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•4 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•