1089909 - Provide a hint when pushed review requests aren't public

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P1)

Description

[Gregory Szorc [:gps]]

As part of improving the user documentation for MozReview, I realized that the push workflow isn't obvious. e.g.

  $ hg push -r 2 review
  pushing to review
  searching for changes
  remote: adding changesets
  remote: adding manifests
  remote: adding file changes
  remote: added 1 changesets with 1 changes to 1 files (+1 heads)
  submitting 1 changesets for review

  changeset:  2:a21bef69f0d4
  summary:    Bug 123 - Implement foo
  review:     https://reviewboard.mozilla.org/r/8 (pending)

  review id:  bz://123/mynick
  review url: https://reviewboard.mozilla.org/r/7 (pending)

  $

WHAT DO I DO NOW?

We know the user should open the review url. We should give them a hint to do that.

P1 because UI wort and trivial to implement (hardest part is updating the tests to expect the new output).

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: bz://1089909/gps

Comment 2

[Gregory Szorc [:gps]]

/r/330 - reviewboard: add a hint to publish the review (bug 1089909)

Pull down this commit:

hg pull review -r 002c3fff60533ebd2d977a71c75b2b5ba95232f6

Comment 3

[Gregory Szorc [:gps]]

Attachment: MozReview Request: bz://1089909/gps

Comment 4

[Gregory Szorc [:gps]]

/r/5 - reviewboard: add a hint to publish the review (bug 1089909)

Pull down this commit:

hg pull review -r c7b27a972c398b5d6158b26a02f74cc16e3ff101

Comment 5

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/3/#review1

I'm going to assume you ran the tests and they pass (you didn't miss any string updates).

Ship-it!

Comment 6

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/c7b27a972c39

Comment 8

[Gregory Szorc [:gps]]

Attachment: MozReview Request: reviewboard: add a hint to publish the review (bug 1089909)