[rbbz] Remove login-group restriction

RESOLVED FIXED

Status

MozReview
General
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: mcote, Assigned: mcote)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
We're just about ready to open MozReview to the public.  Any BMO user will be able to use the system.
(Assignee)

Comment 1

4 years ago
Created attachment 8512384 [details]
MozReview Request: bz://1089936/mcote
(Assignee)

Comment 2

4 years ago
/r/332 - Bug 1089936 - Remove login-group restriction.

Pull down this commit:

hg pull review -r 1f51912563b68075fefdf8ba3c8869e378cf1607
(Assignee)

Comment 3

4 years ago
/r/332 - Bug 1089936 - Remove login-group restriction.

Pull down this commit:

hg pull review -r 1f51912563b68075fefdf8ba3c8869e378cf1607
(Assignee)

Updated

4 years ago
Attachment #8512384 - Flags: review?(gps)
(Assignee)

Comment 4

4 years ago
/r/332 - Bug 1089936 - Remove login-group restriction.

Pull down this commit:

hg pull review -r 1f51912563b68075fefdf8ba3c8869e378cf1607
(Assignee)

Comment 5

4 years ago
Sorry for the spam; this might be another bug, if you publish an already-published review request but with no actual changes.

Updated

4 years ago
Attachment #8512384 - Flags: review?(gps) → review+

Comment 6

4 years ago
https://reviewboard-dev.allizom.org/r/331/#review219

LGTM.

There are still a few references to this group in the test code that could be deleted as well.
https://hg.mozilla.org/hgcustom/version-control-tools/file/89f12dc59e95/testing/vcttesting/mozreview.py#l87
https://hg.mozilla.org/hgcustom/version-control-tools/file/89f12dc59e95/hgext/reviewboard/tests/helpers.sh#l65

r+ carried forward to delete those (but please run tests before landing just in case).
(Assignee)

Comment 7

4 years ago
Removed those two lines and ran tests; they still pass.

http://hg.mozilla.org/hgcustom/version-control-tools/rev/b93beffe770f
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Version: Trunk → unspecified
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.