Closed Bug 1089941 Opened 10 years ago Closed 9 years ago

[Gallery] Deleting multiple images in Gallery, the screen will flicker

Categories

(Core :: Panning and Zooming, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED INCOMPLETE
blocking-b2g -
Tracking Status
b2g-v2.0 --- unaffected
b2g-v2.1 --- affected
b2g-v2.2 --- affected

People

(Reporter: psiphantong, Unassigned)

References

()

Details

(Keywords: regression, Whiteboard: [2.1-exploratory-3])

Attachments

(1 file)

Attached file gg.txt
Description:
When the user selects/delete 50+ images in Gallery, the screen will flicker

Setup Steps:
1) Flame device is set to 319mb, have 50+ images in gallery

Repro Steps:
1) Update a Flame device to BuildID: 20141027001201
2) Go to Gallery > Select all images
3) Tap the trash icon


Actual:
the screen will flicker

Expected:
No screen flicker


Flame 2.1 

Environmental Variables:
Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141027001201
Gaia: c97463d61f45513a2123b19610386ddbfc916819
Gecko: 4f8c0c021128
Version: 34.0 (2.1)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Note: Depending on how many images/videos are in the gallery, the flicker will last longer


Repro frequency: 100%
See attached: video, logcat, https://www.youtube.com/watch?v=vnPIEpCekvA
This issue also reproduces on the Flame 2.2, the screen will flicker

Flame 2.2

Eronmental Variables:
Device: Flame Master (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141027040237
Gaia: e91d99e4d96954f06383c00bb9d79598a697e310
Gecko: 8230834302c9
Version: 36.0a1 (Master)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

--------------------------------------------------------------------------------------------------------- 

This issue does not reproduce on the Flame 2.0, No screen flicker

Flame 2.0

Device: Flame 2.0 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141027000202
Gaia: 2183b4f3ec0eb47ab1f133c31732ec53b08ad253
Gecko: 43bee45176c4
Version: 32.0 (2.0)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(dharris)
[Blocking Requested - why for this release]:

Nominating this as a blocker because the flickering is very apparent and can happen for longer when more photos are being deleted. Also this is a regression
blocking-b2g: --- → 2.1?
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(dharris)
QA Contact: jmercado
Bug 967844 seems to be the cause of this issue.

Mozilla-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 2.1
BuildID: 20140902021513
Gaia: 44bf2e3bc5ddea9db9a8c851bd353cb234aa883c
Gecko: 39a8d9b2b639
Version: 34.0a1 (2.1) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken 
Environmental Variables:
Device: Flame 2.1
BuildID: 20140902025713
Gaia: 44bf2e3bc5ddea9db9a8c851bd353cb234aa883c
Gecko: ea4cfd84e417
Version: 34.0a1 (2.1) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Last Working gaia / First Broken gecko - Issue DOES occur
Gaia: 44bf2e3bc5ddea9db9a8c851bd353cb234aa883c
Gecko: ea4cfd84e417

First Broken gaia / Last Working gecko - Issue does NOT occur
Gaia: 44bf2e3bc5ddea9db9a8c851bd353cb234aa883c
Gecko: 39a8d9b2b639

Gecko Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=39a8d9b2b639&tochange=ea4cfd84e417
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmitchell)
broken by Bug 967844 - can you take a look Robert
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmitchell) → needinfo?(roc)
QA Contact: jmercado
Component: Gaia::Gallery → Panning and Zooming
Product: Firefox OS → Core
(In reply to pete siphantong [:Petes] from comment #0)
> Created attachment 8512338 [details]
> gg.txt
> 
> Description:
> When the user selects/delete 50+ images in Gallery, the screen will flicker
> 
> Setup Steps:
> 1) Flame device is set to 319mb, have 50+ images in gallery

How do I set it to 319MB?
Is there an easy way to fill the gallery with images?
Is there an easy way to select all images?
Flags: needinfo?(roc) → needinfo?(psiphantong)
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #5)
> Is there an easy way to fill the gallery with images?

Reference workloads should help for that. https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/make_options_reference#Reference_Workloads just do "make reference-workload-heavy" in the gaia directory to add a bunch of stuff to the phone.
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #5)
> (In reply to pete siphantong [:Petes] from comment #0)
> > Created attachment 8512338 [details]
> > gg.txt
> > 
> > Description:
> > When the user selects/delete 50+ images in Gallery, the screen will flicker
> > 
> > Setup Steps:
> > 1) Flame device is set to 319mb, have 50+ images in gallery
> Hi Robert,

> How do I set it to 319MB? comment 7
> Is there an easy way to fill the gallery with images? comment 6, tested on x-heavy
> Is there an easy way to select all images? No, don't believe there was ever an option for that
Flags: needinfo?(psiphantong)
I did all those things but I can't reproduce the bug. I don't see any flicker. Not sure how to proceed.

My build has the fix for bug 1092543 in it, which might possibly help.
I was unable to reproduce on a master build even without bug 1092543. qawanted to retest on 2.2 to see if it is still happening, and provide more detailed STR if possible.
Keywords: qawanted
I'm also not able to reproduce this bug on the 2.2. I had to use the 11/5 build because the 11/6 build has a broken camera. No strange flashing seen when deleting large amounts of images in the gallery on 319mb.

Environmental Variables:
Device: Flame 2.2
BuildID: 20141105120748
Gaia: 7918024c737c4570cacd784f267e28737ae05dea
Gecko: b6cd2dd85b26
Gonk: Could not pull gonk.  Did you shallow Flash?
Version: 36.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0


I have been able to reproduce this on 2.1 however so I know what it looks like when it does happen.
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(jmitchell)
Keywords: qawanted
Thanks. Can you also see if this repros on the latest 2.1 build? If not then we should just close this bug. If it does repro on 2.1, then we should get a fix window for 2.2, using the info in comment 1 and comment 11, and the uplift the thing that fixed it.
Yes this repro's on the latest 2.1 KK build with 319mb.

Environmental Variables:
Device: Flame 2.1 KK
BuildID: 20141105133152
Gaia: 9658b93b412bdcc0f953d668e8c8e68318c99fb8
Gecko: 76880403db44
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Regressionwindow-wanted tag to get the 'fixed' window for 2.2
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmitchell)
This bug actually still reproduces on 2.2 so a reverse window can't be done. I used 50 images all taken by Flame's camera and it's a 3/3 repro rate for me. Not sure if this helps - subject of the photos is my keyboard, and all images are taken in portrait orientation.

Device: Flame (shallow flash, 319MB memory)
BuildID: 20141105120748
Gaia: 7918024c737c4570cacd784f267e28737ae05dea
Gecko: b6cd2dd85b26
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmitchell)
Pi Wei - Your 2.2 repro is in BuildID: 20141105120748

The patch mentioned by Roc in comment 9  (bug 1092543) did not land until Thu Nov 06 12:50:56

Please check on the latest Mozilla-Inbound build to see if this repro's - if it does not then the fixed-window will probably point to the aforementioned patch; please confirm that window.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmitchell) → needinfo?(pcheng)
Keywords: qawanted
Currently we can't test on latest 2.2 because camera is broken (as comment 11 mentioned) and I can't copy & paste images from PC to phone because phone storage isn't detected which seems to be the cause of camera breakage. Leaving qawanted tag to re-check after the camera/storage bug has been fixed.

I checked the window on comment 3 and it is correct.
Flags: needinfo?(pcheng)
For tracking purpose, bug 1094808 is blocking us to test on latest master.
This issue still occurs as of the latest Mozilla-inbound tinderbox build which is after the time mentioned in comment 16.

Environmental Variables:
Device: Flame 2.2
BuildID: 20141106134417
Gaia: 1b974ce130eed3988ff5d012c7bd8431c4aba93b
Gecko: bb6355a9cdc0
Version: 36.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmitchell)
Keywords: qawanted
it seems like the fix for bug 1092543 did not fix this as this issue still occurs.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmitchell)
I'm still unable to reproduce this on the latest master build. I tried both using the x-heavy reference workload as well as 51 shots I took from the camera. In both cases I didn't see any flickering.
The behavior looks more like a graphical twitching(?), while deleting if you keep an eye on the upper right corner of Gallery you will see it.
I think the STR might be missing something. Can you provide an updated video? I noticed that the video linked in comment 0 was deleting less than 50 items so it didn't quite match the STR. Other factors might be relevant, like whether or not the screen scrolls while deleting the images, or if the final state (after deleting the images) has less than one screenful of images and therefore cannot be scrolled.
qawanted for an updated video on latest 2.2 addressing comment 23.
Keywords: qawanted
The triage group talked about this today and we decided that the flickering behaviour here doesn't warrant blocking the release.  Stephany agreed from a UX perspective.
blocking-b2g: 2.1? → -
Updated video:

http://youtu.be/w3t7hQTE_Mo

Device: Flame
BuildID: 20141114042015
Gaia: 1e300eac2e56d98ad51d414766d031db7d33221f
Gecko: 64206634959a
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(jmitchell)
Keywords: qawanted
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmitchell)
Given the nonblocking status and difficulty in reproducing this bug, plus the fact that nobody else has reported anything like this, I'm going to say we're not planning to fix this. Not a WONTFIX because we would still accept a patch for it if it fell out of the sky.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: