Closed
Bug 1090022
Opened 10 years ago
Closed 10 years ago
[mozrunner] Allow storing crashdumps by default
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: mdas, Assigned: mdas)
References
Details
Attachments
(1 file, 1 obsolete file)
1.67 KB,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
If you use mozrunner to start an instance, it will run check_for_crashes() for you. If you want to save crash dumps, you can only do so by calling check_for_crashes explicitly by passing dump_save_path. I'd like to have mozrunner store minidumps whenever it runs check_for_crashes(), especially because it does so implicitly.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → mdas
Attachment #8512430 -
Flags: review?(ahalberstadt)
Comment 2•10 years ago
|
||
In case it helps, you can also set the MINIDUMP_SAVE_PATH environment variable.
Comment 3•10 years ago
|
||
Comment on attachment 8512430 [details] [diff] [review] dumpsavepath Review of attachment 8512430 [details] [diff] [review]: ----------------------------------------------------------------- Seems reasonable. Though this kind of makes me think that we should push most of this dump logic out to mozcrash and have the ability to set defaults at a more global level there. We're violating the single responsibility principle a bit here. But that's another bug for another time. ::: testing/mozbase/mozrunner/mozrunner/base/runner.py @@ +45,4 @@ > self.process_class = process_class or ProcessHandler > self.process_args = process_args or {} > self.symbols_path = symbols_path > + self.dump_save_path = dump_save_path nit: whitespace
Attachment #8512430 -
Flags: review?(ahalberstadt) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8512430 -
Attachment is obsolete: true
Attachment #8512704 -
Flags: review?(ahalberstadt)
Updated•10 years ago
|
Attachment #8512704 -
Flags: review?(ahalberstadt) → review+
Assignee | ||
Comment 5•10 years ago
|
||
thanks, landed https://hg.mozilla.org/integration/mozilla-inbound/rev/10dff2924f03
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/10dff2924f03
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•