1090036 - Consider forgoing `disable-user-select` Stylus mixin

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Christopher Van Wiemeersch [:cvan]]

There is a `disable-user-select` mixin that seems to be added specifically for the swipeable (ATM not swipeable anymore but will be again soon) nav:

https://github.com/mozilla/fireplace/commit/fd6c37b#diff-0dff60406e12280179366dfb014bba03R407

https://developer.mozilla.org/en-US/docs/Web/CSS/user-select

> Non-standard
> This feature is non-standard and is not on a standards track. Do not use it on production sites facing the Web: it will not work for every user. There may also be large incompatibilities between implementations and the behavior may change in the future.

I can understand how it can be useful to disallow users from selecting text in buttons, tabs, headers, etc. (that's what OSes do with native prompts, panes, windows, etc.), but what if the user does want to select the text?

Was this added originally because swiping the text triggered a selection of text? I likely don't understand why this was added, and my concerns about accessibility may be unwarranted here. So apologies if I'm off base here.

Comment 1

[Kevin Ngo [:ngoke]]

Fixed with the new Nav.

We no longer use disable-user-select, and we removed the mixin now that we use autoprefixer.

Steps to See the Fix:

1. Go to Debug page.
2. Click Enable new mkt-nav

Comment 2

[Madalin Cotetiu]

Verified as fixed in FF40(Win7) in marketplace.allizom.org
Postfix screencast: http://screencast.com/t/RAtvUPDZZLu
The text from the navigation can now be selected. Is there anything else needed to be tested here?