[B2G][Message] MMS attachments missed in SMIL could not be displayed

RESOLVED FIXED

Status

Firefox OS
Gaia::SMS
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: steveck, Assigned: steveck)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
julienw
: review+
Details | Review | Splinter Review
(Assignee)

Description

4 years ago
+++ This bug was initially created as a clone of Bug #996755 +++

Description:
When the user receives an MMS with attachment not in the SMIL layout, the attachment won't be able to display on the message thread.

Repro Steps:
1) Sending a MMS with v-calender file from Android device(the target device here is samsung s2)
2) Open the MMS on the device

Actual:
The device does not display v-calender file 

Expected:
The device will show v-calender file as unknown file type

Please note the solution here might solve Bug #996755 as well, so it will need QA's help to verify once this fix landed.
(Assignee)

Comment 1

4 years ago
Created attachment 8512587 [details] [review]
Link to github

Hi Julien, in this patch we will check the attachment count and make sure all the attachment should be displayed in thread, and I also address some change to make sure the 'application' prefix mimetype file visible in the thread
Attachment #8512587 - Flags: review?(felash)
Comment on attachment 8512587 [details] [review]
Link to github

r=me with 2 nits :)

thanks
Attachment #8512587 - Flags: review?(felash) → review+
(Assignee)

Comment 3

4 years ago
Thanks!

In master: 872f8d3fe6e5f6b6101ff4ce5e895fea2aa8c451
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.