109008 - Footer on create attachment page looks wrong.

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect, P2)

Description

[Matthew Tuck [:CodeMachine]]

The footer looks wrong on the create attachment page.

In N4, it has a very thick top border and too much vertical space.

In Mozilla, it has a very thick bottom border.

Comment 1

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 2

[Bradley Baetz (:bbaetz)]

-> me, this is now annoying me enough for me to actually fix it.

Comment 3

[Bradley Baetz (:bbaetz)]

Attachment: v1

OK, try this. Uses a class instead of an id in the show-multiple case because
you can't have more than one element with the same id, and uses it in the other
places for consistency.

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 90492 [details] [diff] [review]
v1

2xr=gerv

Gerv

Comment 5

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.9; previous revision: 1.8
done
Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: 1.9; previous revision: 1.8
done
Checking in template/en/default/attachment/show-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/show-multiple.html.tmpl,v
 <--  show-multiple.html.tmpl
new revision: 1.6; previous revision: 1.5
done

Gerv