1090097 - [settings] refactor SIM Manager with AMD pattern

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Overview Description:

Refactor Firefox Accounts panel with AMD pattern referring to
https://github.com/gasolin/gaia/tree/master/apps/settings

to make it modularize and more easier to maintain


Expected Results:

pass all settings test and act the same as original implementation

Additional Information:

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master(2.2)

Hi Arthur,

I just updated SimCardManager with better structure and it was re-written in AMD now. There are no functionalities got changed here and just want to make sure the direction is ok.

I am actively writing tests and jsdocs now, would update any news about it later.

Any feedback / idea would be appreciated ! Thanks

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Great news, just totally rewrote all test files (removed some legacy codes and use some modern way (?) to make it look nice) and added jsdoc !

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8513183 [details] [review]
patch on master(2.2)

Yeah, jsdocs added, tests fixed ! I think this patch is ready to be reviewed, thanks Arthur !

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8513183 [details] [review]
patch on master(2.2)

Looks good to me! r=me with the nits addressed, thanks.

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks Arthur, merged into Gaia/master(2.2) : https://github.com/mozilla-b2g/gaia/commit/5c22ab657bf06664ca084c12d86343e12f309c00