userMac can be passed into urlData and is also the first option in addUserCallUrlData. https://github.com/mozilla-services/loop-server/blob/master/loop/storage/redis.js#L129 In case userMac is already present in urlData, we need to decide if it supersedes the first option. Or if a call to that function with a userMac in urlData is consider invalid?
It shouldn't be set in urlData but should be added using the method parameter.
It's done everywhere in the tests, example : https://github.com/mozilla-services/loop-server/blob/master/test/functional_test.js#L913 Feedback from Rémy: this is going to be fixed in the mysql branch.
It has been fixed by this commit: https://github.com/mozilla-services/loop-server/commit/55e78477de2a31a7f871939d295a9434697290cb Also I noticed that some calls where made with undefined inside the redis key name. I am adding a PR to make sure this never happens.
Assignee: nobody → rhubscher
Status: NEW → ASSIGNED
Created attachment 8523853 [details] [review] Link to GitHub PR.
Attachment #8523853 - Flags: review?(alexis+bugs)
Comment on attachment 8523853 [details] [review] Link to GitHub PR. https://github.com/mozilla-services/loop-server/commit/2f6a29cc5c41d82e7b4ec59734cbf4b818a4775b
Attachment #8523853 - Flags: review?(alexis+bugs) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.