clarify userMac option for addUserCallUrlData

RESOLVED FIXED

Status

Hello (Loop)
Server
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: tarek, Assigned: natim)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
userMac can be passed into urlData and is also the first option in addUserCallUrlData.


https://github.com/mozilla-services/loop-server/blob/master/loop/storage/redis.js#L129

In case userMac is already present in urlData, we need to decide if it supersedes the first option.

Or if a call to that function with a userMac in urlData is consider invalid?
(Assignee)

Comment 1

4 years ago
It shouldn't be set in urlData but should be added using the method parameter.
(Reporter)

Comment 2

4 years ago
It's done everywhere in the tests, example : https://github.com/mozilla-services/loop-server/blob/master/test/functional_test.js#L913

Feedback from Rémy: this is going to be fixed in the mysql branch.
(Assignee)

Comment 3

4 years ago
It has been fixed by this commit: https://github.com/mozilla-services/loop-server/commit/55e78477de2a31a7f871939d295a9434697290cb

Also I noticed that some calls where made with undefined inside the redis key name.
I am adding a PR to make sure this never happens.
Assignee: nobody → rhubscher
Status: NEW → ASSIGNED
(Assignee)

Comment 4

4 years ago
Created attachment 8523853 [details] [review]
Link to GitHub PR.
Attachment #8523853 - Flags: review?(alexis+bugs)
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.