[mozlog] Remove test class from HTML formatter

RESOLVED FIXED in mozilla36

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: davehunt, Assigned: davehunt)

Tracking

Trunk
mozilla36
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
+++ This bug was initially created as a clone of Bug #1065406 +++

We just need a way of identifying the test in the HTML report, so there's no need to split it into class/method.
(Assignee)

Updated

4 years ago
No longer blocks: 1065410
(Assignee)

Comment 1

4 years ago
Created attachment 8512555 [details] [diff] [review]
Remove test class from HTML formatter. v1.0

This also include a small fix for the CSS to display the correct colours in the report.
Attachment #8512555 - Flags: review?(james)
(Assignee)

Comment 2

4 years ago
Comment on attachment 8512555 [details] [diff] [review]
Remove test class from HTML formatter. v1.0

Chris has said he can take this review.
Attachment #8512555 - Flags: review?(james) → review?(cmanchester)
Comment on attachment 8512555 [details] [diff] [review]
Remove test class from HTML formatter. v1.0

Review of attachment 8512555 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure of the intent of the original code, so I'd be a little curious to know why the empty column ended up here in the first place. I'm also not sure who else might be using this for reports or how.

But the change is reasonable and the report it produces looks good! Worst case scenario we can roll back if anything unexpected comes up.

::: testing/mozbase/mozlog/mozlog/structured/formatters/html/html.py
@@ +146,5 @@
>              additional_html.append(log)
>  
>          self.result_rows.append(
>              html.tr([html.td(status_name, class_='col-result'),
> +                     html.td(unicode(data["test"]), class_='col-name'),

"test" fields are always coerced to unicode before reaching the formatter now, you can leave out the coercion here if you like.
Attachment #8512555 - Flags: review?(cmanchester) → review+
https://hg.mozilla.org/mozilla-central/rev/c891f30c5a5f
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.