1090152 - Status bar is empty on lockscreen on full screen apps

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Guillaume Marty [:gmarty]]

STR:
1. Launch a fullscreen app (Camera or Cut the Rope)
2. Press the power button twice to display the lockscreen
3. See that the status bar is empty

Expected:
The status bar should show icons.

Reproducible on v2.1 and master

Comment 1

[Guillaume Marty [:gmarty]]

[Blocking Requested - why for this release]:
Regression from v1.4 (Bug 972277)

Comment 2

[Dietrich Ayala (:dietrich)]

Lockscreen not required with today's Flame nightly channel build.

STR:

1. open camera

notice the black strip on top (icon-less status bar?)
hit home button and watch the icons flash in the black strip before the app closes

Triage group reviewed, blocking+ for regression.

Comment 3

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

I think this is a dupe of bug 1088826

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

not sure if this is something your team can help.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Let's see if this is under Gregor's radar first?

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

qawanted for branch checks. I'll take a look at 2.1 in the meantime.

Comment 9

[Cody Roesch [:croesch]]

Tested with Shallow Flash on 319mb using Engineering builds

This bug repro's on Flame KK builds: Flame 2.2 KK, Flame 2.1 KK, 

Actual Results: Empty status bar after tapping power button twice while in the camera app or other fullscreen apps.

Repro Rate: 4/4

Environmental Variables:
Device: Flame 2.2 KK
BuildID: 20141031062029
Gaia: a07994714f0552f89801d6097982308d8b0a1ee1
Gecko: 21fbf1e35090
Version: 36.0a1 (2.2) 
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 2.1 KK
BuildID: 20141031025654
Gaia: 224dfde17af943b583aa0a97936343c7267c7996
Gecko: 12a56ce89cb9
Version: 34.0 (2.1) 
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

-----------------------------------------------------------------
-----------------------------------------------------------------

This bug does NOT repro on Flame kk build: Flame 2.0 KK

Actual Result: Status bar icons do not disappear when checking the lockscreen after running a fullscreen app.

Repro Rate: 0/4

Environmental Variables:
Device: Flame 2.0 KK
BuildID: 20141030181855
Gaia: 7b8df9941700c1f6d6d51ff464f0c8ae32008cd2
Gecko: 82a6ed695964
Version: 32.0 (2.0) 
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 10

[Michael Henretty [:mikehenrty][:mhenretty]]

Caused by bug 1081319, ie if we backout [1] the problem is fixed. Yura, can you take a look here?

1.) https://github.com/mozilla-b2g/gaia/commit/7c7eecb8f445698cd04f1b8f8a3904d135456f50

Comment 11

[Ken Chang[:kenkai]]

Hi Gregor, Yura is taking PTO. Should we find someone to fix this bug? Or just roll back the patch causing problems.

Comment 12

[Gregor Wagner [:gwagner]]

David, is there anyone else in your team that can take a look at this regression during Yura is out?

Comment 13

[David Bolter [:davidb] (NeedInfo me for attention)]

Yep! Eitan is your man!

Comment 14

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Ken Chang[:ken] from comment #11)
> Hi Gregor, Yura is taking PTO. Should we find someone to fix this bug? Or
> just roll back the patch causing problems.

Unfortunately, we can't just roll back the patch on bug 1081319 since that one is also a 2.1 blocker. Let's get a fix for this.

Comment 15

[Michael Henretty [:mikehenrty][:mhenretty]]

I'm going to try and get to this today. I'll reach out if I need help.

Comment 16

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [Gaia PR] hide icons in secure app, not lockscreen

Kevin, or Alive, either of you have time for a review?

Comment 17

[Kevin Grandon :kgrandon]

Comment on attachment 8517132 [details] [review]
[Gaia PR] hide icons in secure app, not lockscreen

Since we're investigating this.. Something that used to happen was that the icons used to animate downward with your drag. Do you know why this is missing, and do you think we could restore it? It kind of sucks that it's not there, and it's distracting to see the icons flash in after you pull down the bar.

Comment 18

[Michael Henretty [:mikehenrty][:mhenretty]]

I think what you are referring to is how the date in the upper left used to animate downward. The icons did not animate (except for the notification count), and the utility tray bar did immediately appear just like it does now. However, I agree with you that it is much more jarring now because the animation is missing and the utility tray bar is a completely different color than most statusbars. The net effect is that it looks like the utility tray just pops in more so than before. The transition went with the utility tray refresh in bug 1038723.

I agree that we should restore this (at least the date part), but it's pretty late in the 2.1 game to polish things like this. Also, the work for this shouldn't be done in this bug. I have filed bug 1094459 to track that.

Comment 19

[Kevin Grandon :kgrandon]

No, I am definitely referring to the icons. In fullscreen apps the icons used to come down with the statusbar, instead of come in after the transition. I think the accessibility work broke this, and it's something that we should fix.

Comment 20

[Michael Henretty [:mikehenrty][:mhenretty]]

Ah you are right! I didn't realize you meant the statusbar transition on fullscreen apps, and yeah that does look bad. I'll take a look.

Comment 21

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Kevin Grandon :kgrandon from comment #19)
> No, I am definitely referring to the icons. In fullscreen apps the icons
> used to come down with the statusbar, instead of come in after the
> transition. I think the accessibility work broke this, and it's something
> that we should fix.

Yup, that was caused by bug 1045017, specifically the not(.minimized-tray) part in [1]. I am hesitant to remove that, since I'm not sure why it's there and I might cause another regression. Since Yura is on PTO, I filed bug 1094506 to triage and work on separately.

1.) https://github.com/mozilla-b2g/gaia/commit/60be8b2a07fe250f96fc0379a63ec36b909c0900#diff-19076406e0c835797eb201e0143532c7R52

Comment 22

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8517132 [details] [review]
[Gaia PR] hide icons in secure app, not lockscreen

Kevin is looking!

Comment 23

[Kevin Grandon :kgrandon]

I'm confused with all of the resolved bugs in comment 18 and comment 21.

Mike - where is the bug which would track the work to make the icons come down with the statusbar? I still think that this should be the same fix.

Comment 24

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Kevin Grandon :kgrandon from comment #23)
> I'm confused with all of the resolved bugs in comment 18 and comment 21.
> 
> Mike - where is the bug which would track the work to make the icons come
> down with the statusbar? I still think that this should be the same fix.

That's bug 1094351. I duped the bug I filed (bug 1094506) with it, since that one was filed by QA earlier and had a regression window already.

Comment 25

[Kevin Grandon :kgrandon]

Hmm, sounds like bug 1094351 might be more of a dupe of this bug?

Comment 27

[Kevin Grandon :kgrandon]

Comment on attachment 8517132 [details] [review]
[Gaia PR] hide icons in secure app, not lockscreen

So the code looks fine here, but I really don't want to leave an R+ here because I don't think we should land this without fixing the slide-down appearance at the same time. I suppose this could be done in a different bug, but I want to make sure that this is the right approach, so I want to review both at the same time. If this is bug 1094351 then I will definitely keep an eye on that bug.

Sorry for being a pain here, I just definitely want to make sure that we're on track to land the proper appearance transition. I'd be more than happy to review this one + bug 1094351 when it's ready. Maybe bug 1094351 should rebase on top of this patch?

Comment 29

[Michael Henretty [:mikehenrty][:mhenretty]]

After further investigation, bug 1094351 is indeed a duplicate of this bug. But the transition problem mentioned in comment 19 and 27 is a separate problem caused by bug 1045017, and I reopened bug 1094506 to track it.

I also don't think we should block this bug on that problem for two reasons. First, the statusbar transition problem existed for almost two months before it was found during the review of this fix. This patch only restores things to how they worked before bug 1081319 but after bug 1045017 landed. Second, it's a non-trivial fix because after bug 1045017 landed, the statusbar icons no longer live in the minimized-tray statusbar. So if we use css to display the statusbar icons when transitioning the statusbar on pull-down, the icons don't move with the statusbar but instead immediately show up in their final place. Some statusbar rework will have to be done to get them to transition properly again. I do think we should fix this, but probably not in 2.1.

In any case, I know you probably disagree here, but I think we need to make a blocking decision on bug 1094506 separately from this fix.

Comment 30

[Kevin Grandon :kgrandon]

Comment on attachment 8517132 [details] [review]
[Gaia PR] hide icons in secure app, not lockscreen

I'm hesitant to R+ this because I still strongly believe that we should not land this as-is, without the sliding icons as we used to have.

I think we did a really bad job at landing the accessibility patch, and we need to do a much more careful review pass for these kinds of things in the future.

I'll leave an R+ to fix the blocker for now though. Thanks for the patch.

Comment 31

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/12e2da14efee4fa564759ef64038b6c6cfe4a04b

Comment 32

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [Gaia v2.1 PR]

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Bug 1081319.

[User impact] if declined:
Poor UX, statusbar icons will disappear sometimes.

[Testing completed]:
Manual testing, and added integration test.

[Risk to taking this patch] (and alternatives if risky):
CSS only change that is really specific to bug scenario. Low risk of making the situation any worse.

[String changes made]: none.

Comment 33

[sarsenyev]

Verified the issue is fixed on 2.2 Master Flame

Status bar is shown with icons

"Flame 2.2

Device: Flame 2.2 (319mb)(Kitkat Base)(Shallow Flash)
Build ID: 20141117040203
Gaia: ddf5b92f43ec27c93ad4fea4fd1207da8936b8e7
Gecko: 21b745197618
Version: 36.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0"

Comment 34

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

v2.1: https://github.com/mozilla-b2g/gaia/commit/0af87952f544699f3b1c0118578ad2dd3301ba5f

Comment 35

[Elie]

Attachment: VIDEO0064[1].mp4

This issue still occurs on Flame 2.1
Gaia-Rev        f8d3bf44029e0afc0124600a4bb34dba8fc1ad21
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f70a67a7f846
Build-ID        20141120001207
Version         34.0
Device-Name     flame
FW-Release      4.4.2
STR:
1. Launch a fullscreen app (Camera or Cut the Rope)
2. Press the power button twice to display the lockscreen

Actual:
See that the status bar is empty

Expected:
The status bar should show icons.

Comment 36

[Elie]

Attachment: logcat.txt

This log is for comment 35.
Happen time 10:50

Comment 37

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on on today's nightly Flame 2.1 build. The result from Comment 35 might be before the 2.1 patch was actually landed. 

Result: The status bar icons are displayed properly on the lockscreen from a fullscreen app (tested with Camera, Gallery, Video).

Device: Flame 2.1 (319mb, KK, Shallow Flash)
BuildID: 20141121001202
Gaia: 6c739275e963465658c18c7a9ebaa48cbe927d34
Gecko: 9bfc7a166a94
Version: 34.0 (2.1) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0