Closed Bug 1090201 Opened 5 years ago Closed 5 years ago

Intermittent leakcheck | geckomediaplugin process: 1856 bytes leaked (GMPThread, MessagePump, Mutex, WaitableEventKernel)

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36
Tracking Status
firefox34 --- unaffected
firefox35 --- unaffected
firefox36 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: cbook, Assigned: mccr8)

References

(Blocks 1 open bug, )

Details

(Keywords: intermittent-failure, memory-leak)

Attachments

(1 file)

Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound debug test mochitest-2

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3352259&repo=mozilla-inbound

04:48:21 WARNING - TEST-UNEXPECTED-FAIL | leakcheck | geckomediaplugin process: 1856 bytes leaked (GMPThread, MessagePump, Mutex, WaitableEventKernel)
04:48:21 INFO - TEST-INFO | leakcheck | geckomediaplugin process: ignoring missing output line for total leaks
04:48:21 INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, plugin process 993
04:48:21 INFO - |<----------------Class--------------->|<-----Bytes------>|<----------------Objects---------------->|<--------------References-------------->|
04:48:21 INFO - Per-Inst Leaked Total Rem Mean StdDev Total Rem Mean StdDev
04:48:21 INFO - 0 TOTAL 44 0 557 0 ( 21.45 +/- 24.63) 1491 0 ( 23.35 +/- 41.17)
04:48:21 INFO - nsTraceRefcnt::DumpStatistics: 25 entries
04:48:21 INFO - TEST-PASS | leakcheck | plugin process: no leaks detected!
04:48:21 INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, plugin process 996
04:48:21 INFO - |<----------------Class--------------->|<-----Bytes------>|<----------------Objects---------------->|<--------------References-------------->|
04:48:21 INFO - Per-Inst Leaked Total Rem Mean StdDev Total Rem Mean StdDev
04:48:21 INFO - 0 TOTAL 39 0 630 0 ( 23.77 +/- 25.91) 1095 0 ( 42.00 +/- 55.44)
04:48:21 INFO - nsTraceRefcnt::DumpStatistics: 25 entries
04:48:21 INFO - TEST-PASS | leakcheck | plugin process: no leaks detected!
04:48:21 INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, tab process 1001
04:48:21 INFO - |<----------------Class--------------->|<-----Bytes------>|<----------------Objects---------------->|<--------------References-------------->|
04:48:21 INFO - Per-Inst Leaked Total Rem Mean StdDev Total Rem Mean StdDev
04:48:21 INFO - 0 TOTAL 35 4968 87450 33 ( 2498.59 +/- 2949.46) 191895 17 ( 890.30 +/- 2108.54)
04:48:21 INFO - 6 AsyncTransactionTrackersHolder 72 72 10 1 ( 5.26 +/- 2.83) 0 0 ( 0.00 +/- 0.00)
04:48:21 INFO - 35 CompositorChild 792 1584 2 2 ( 1.50 +/- 0.71) 1 1 ( 1.00 +/- 0.00)
04:48:21 INFO - 36 CondVar 40 80 7 2 ( 4.00 +/- 1.86) 0 0 ( 0.00 +/- 0.00)
04:48:21 INFO - 124 MessagePump
weird, I wonder why this started actually getting leak logs, only on 10.6.  I'll bump up the threshold to 20kb or something.
Assignee: nobody → continuation
Hopefully the size of the leak will not quadruple every two weeks. ;)
See Also: → 1082788
Blocks: 1065098
before it was:
11:29:24 INFO - TEST-INFO | leakcheck | geckomediaplugin process: leaked 2 GMPThread (176 bytes)
11:29:24 INFO - TEST-INFO | leakcheck | geckomediaplugin process: leaked 2 MessagePump (32 bytes)
11:29:24 INFO - TEST-INFO | leakcheck | geckomediaplugin process: leaked 2 Mutex (64 bytes)
11:29:24 INFO - TEST-INFO | leakcheck | geckomediaplugin process: leaked 2 WaitableEventKernel (192 bytes)

now it is:
04:48:21 INFO - TEST-INFO | leakcheck | geckomediaplugin process: leaked 8 GMPThread (704 bytes)
04:48:21 INFO - TEST-INFO | leakcheck | geckomediaplugin process: leaked 8 MessagePump (128 bytes)
04:48:21 INFO - TEST-INFO | leakcheck | geckomediaplugin process: leaked 8 Mutex (256 bytes)
04:48:21 INFO - TEST-INFO | leakcheck | geckomediaplugin process: leaked 8 WaitableEventKernel (768 bytes)

So clearly we're leaking some amount per thread or something, maybe per test that is run, so that's not great.  Still, it is fairly small per thread or whatever.
We can't really tighten the screws here until we're getting a leak log consistently, so just increase the leak threshold a little more.

We'll still notice catastrophic leaks, if they start up.
Attachment #8512721 - Flags: review?(erahm)
Component: General → Video/Audio
I filed bug 1090294 for the leaking thread issue.
Comment on attachment 8512721 [details] [diff] [review]
Increase GMP process leak threshold a little more.

Review of attachment 8512721 [details] [diff] [review]:
-----------------------------------------------------------------

r=me Can you explicitly state that we need to reduce this again in the follow up bug?
Attachment #8512721 - Flags: review?(erahm) → review+
(In reply to Eric Rahm [:erahm] from comment #8)
> Can you explicitly state that we need to reduce this again in the follow up bug?

Good point!  Done.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/553410a1e458
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.