1090265 - Add Marionette tests for status bar icons features

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Guillaume Marty [:gmarty]]

The basic features and use cases of the status bar icon prioritisation should be covered by Marionette tests.

Comment 1

[Guillaume Marty [:gmarty]]

Attachment: Github PR for testing the time icon

This first patch is testing the basic feature of the time icon. What do you think Etienne?

Comment 2

[Etienne Segonzac (:etienne)]

Comment on attachment 8512720 [details] [review]
Github PR for testing the time icon

left some comments on github, but I think we'll need at least one test where the time disappears because we're displaying too many prioritized icon to consider this bug fixed :)

Comment 3

[Guillaume Marty [:gmarty]]

Thanks for the comment, I'll work on it.

The goal of this bug is to hold a reference to many different patches, the time icon one being the first one.
I definitely plan on testing the prioritisation mechanism, but first I'm trying to test each icon features independently.

Comment 4

[Guillaume Marty [:gmarty]]

Attachment: Github PR for testing icons prioritisation

Etienne, here is a basic test for icon prioritisation. Can you have a look?

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 8516656 [details] [review]
Github PR for testing icons prioritisation

comments on github, let me know what you think

Comment 6

[Guillaume Marty [:gmarty]]

Comment on attachment 8516656 [details] [review]
Github PR for testing icons prioritisation

Took this discussion offline and addressed Etienne's concerns. How does it look now?

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 8516656 [details] [review]
Github PR for testing icons prioritisation

good compromise!
let's make sure this isn't intermittent (by retriggering 10-20 times) and land this baby :)

Comment 8

[Guillaume Marty [:gmarty]]

The icons prioritisation integration test landed in master in https://github.com/mozilla-b2g/gaia/commit/f90af6ed55795d13d16e1a4d7745643a124b4001

Keeping this bug open while we add more tests.

Comment 9

[Guillaume Marty [:gmarty]]

Comment on attachment 8512720 [details] [review]
Github PR for testing the time icon

I gave up on trying to mock mozTime and Date in b2g-desktop. This is just a quick test to make sure the time in status bar doesn't show on lockscreen.

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 8512720 [details] [review]
Github PR for testing the time icon

comment on github!

Comment 11

[Guillaume Marty [:gmarty]]

Comment on attachment 8516656 [details] [review]
Github PR for testing icons prioritisation

This patch is obsolete.

Comment 12

[Guillaume Marty [:gmarty]]

Closing as the code changed since this bug was opened.