Closed Bug 1090265 Opened 7 years ago Closed 6 years ago

Add Marionette tests for status bar icons features

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gmarty, Assigned: gmarty)

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

The basic features and use cases of the status bar icon prioritisation should be covered by Marionette tests.
Assignee: nobody → gmarty
This first patch is testing the basic feature of the time icon. What do you think Etienne?
Attachment #8512720 - Flags: review?(etienne)
Comment on attachment 8512720 [details] [review]
Github PR for testing the time icon

left some comments on github, but I think we'll need at least one test where the time disappears because we're displaying too many prioritized icon to consider this bug fixed :)
Attachment #8512720 - Flags: review?(etienne)
Thanks for the comment, I'll work on it.

The goal of this bug is to hold a reference to many different patches, the time icon one being the first one.
I definitely plan on testing the prioritisation mechanism, but first I'm trying to test each icon features independently.
Whiteboard: [systemsfe]
Etienne, here is a basic test for icon prioritisation. Can you have a look?
Attachment #8516656 - Flags: review?(etienne)
Comment on attachment 8516656 [details] [review]
Github PR for testing icons prioritisation

comments on github, let me know what you think
Attachment #8516656 - Flags: review?(etienne)
Comment on attachment 8516656 [details] [review]
Github PR for testing icons prioritisation

Took this discussion offline and addressed Etienne's concerns. How does it look now?
Attachment #8516656 - Flags: review?(etienne)
Comment on attachment 8516656 [details] [review]
Github PR for testing icons prioritisation

good compromise!
let's make sure this isn't intermittent (by retriggering 10-20 times) and land this baby :)
Attachment #8516656 - Flags: review?(etienne) → review+
The icons prioritisation integration test landed in master in https://github.com/mozilla-b2g/gaia/commit/f90af6ed55795d13d16e1a4d7745643a124b4001

Keeping this bug open while we add more tests.
Comment on attachment 8512720 [details] [review]
Github PR for testing the time icon

I gave up on trying to mock mozTime and Date in b2g-desktop. This is just a quick test to make sure the time in status bar doesn't show on lockscreen.
Attachment #8512720 - Flags: review?(etienne)
Summary: Add Marionette tests for status bar icons prioritisation → Add Marionette tests for status bar icons features
Comment on attachment 8512720 [details] [review]
Github PR for testing the time icon

comment on github!
Attachment #8512720 - Flags: review?(etienne)
Comment on attachment 8516656 [details] [review]
Github PR for testing icons prioritisation

This patch is obsolete.
Attachment #8516656 - Flags: review+
Closing as the code changed since this bug was opened.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.